[Devel] [PATCH hci-8.1 v2] selftests: forwarding: flush neighbours in the locked port MAB test

[Eva Kurchatova]

locked_port_mab starts with the neighbour entry for 192.0.2.2 that
locked_port_ipv4 left behind, and the locked bridge port then drops
h1's traffic for two pings, long enough for that entry to time out.
The locked ping starts a broadcast resolution, which the port drops as
well. When it fails after the FDB entry is replaced, the next ping has
already queued its first packet and gets "Destination Host
Unreachable", and since ping runs with a deadline, it stops at that
error. The check "Ping did not work after replacing FDB entry" then
fails.

Flush h1's neighbours after replacing the FDB entry, so that the ping
starts a fresh resolution.

Fixes: 4a331d346996 ("selftests: forwarding: Add MAC Authentication Bypass (MAB) test cases")
https://virtuozzo.atlassian.net/browse/VSTOR-153057
Feature: fix selftests

Signed-off-by: Eva Kurchatova <eva.kurchatova at virtuozzo.com>
---

Changes in v2:
- Flush only in locked_port_mab, the one case where the entry is old
  enough to time out while the port is locked; the ipv6 flush hid the
  failure by removing that entry early. Keep only the Fixes tag of the
  MAB test.
- Describe the resolution.

 tools/testing/selftests/net/forwarding/bridge_locked_port.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
index c62331b2e006..e0bf223d5f46 100755
--- a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
+++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
@@ -201,6 +201,7 @@ locked_port_mab()
 	check_err $? "Locked FDB entry not created"
 
 	bridge fdb replace `mac_get $h1` dev $swp1 master static
+	ip neigh flush dev $h1
 
 	ping_do $h1 192.0.2.2
 	check_err $? "Ping did not work after replacing FDB entry"
-- 
2.56.0