[Devel] [PATCH hci-8.1] selftests: forwarding: flush neighbours in the bridge locked port test

[Eva Kurchatova (Virtuozzo)]

On 11/3/26 04:15, no-reply at sashiko.virtuozzo.com wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] selftests: commit message carries downstream-only Jira URL and Feature tag
> --
>
> commit 5c88239541683d62eb566e440a6cf1b940bf6161
> Author: Eva Kurchatova <eva.kurchatova at virtuozzo.com>
>
> selftests: forwarding: flush neighbours in the bridge locked port test
>
> This patch adds "ip neigh flush" calls in bridge_locked_port.sh. Each call
> runs right after the FDB entry is added or replaced, so the next ping starts
> a fresh neighbour resolution instead of failing on a stale entry.
>
>> selftests: forwarding: flush neighbours in the bridge locked port test
>>
>> [ ... ]
>>
>>      Fixes: b2b681a41251 ("selftests: forwarding: tests of locked port feature")
>>      Fixes: 4a331d346996 ("selftests: forwarding: Add MAC Authentication Bypass (MAB) test cases")
>>      https://virtuozzo.atlassian.net/browse/VSTOR-153057
>>      Feature: fix selftests
>>
>>      Signed-off-by: Eva Kurchatova <eva.kurchatova at virtuozzo.com>
> [Severity: Low]
> This isn't a bug in the code, but the commit message has two downstream-only
> lines:
>
> https://virtuozzo.atlassian.net/browse/VSTOR-153057
> Feature: fix selftests
>
> Upstream reviewers can't open the Jira URL, and "Feature:" isn't a
> recognised kernel trailer. Could both lines be dropped before this goes to
> netdev or linux-kselftest?

Indeed, but this is a Virtuozzo mailing list, and all patches have these 
downstream lines by design. Do we have a way to make Sashiko understand 
this from the get-go in future?

> The change in bridge_locked_port.sh looks fine. In each test the flush comes
> right after the "bridge fdb add" or "bridge fdb replace", before the ping
> that must succeed. The device it flushes (h1, or h1.100 in the VLAN test) is
> the same one the ping uses.
>