[Devel] [PATCH hci-8.1 2/2] ms/selftests/futex: Correct validation logic in waitv
no-reply at sashiko.virtuozzo.com
no-reply at sashiko.virtuozzo.com
Mon Nov 2 23:10:14 MSK 2026
> From: Wake Liu <wakel at google.com>
>
> In futex_waitv negative tests (invalid_flag, unaligned_address, etc.), test
> results are evaluated as:
>
> if (res == EINVAL)
>
> Since sys_futex_waitv returns -1 on error and sets errno, direct positive
> comparisons against res are always false, causing tests to silently pass
> regardless of real errors.
>
> Correct these validations to assert EXPECT_EQ(res, -1) and compare errno
> directly against expected constants.
>
> [ tglx: Fixup coding style ]
> [ ... ]
>
> https://virtuozzo.atlassian.net/browse/VSTOR-152660
> Feature: fix selftests
>
> Signed-off-by: Eva Kurchatova <eva.kurchatova at virtuozzo.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261102200610.2414832-1-eva.kurchatova@virtuozzo.com?part=2
More information about the Devel
mailing list