[Devel] Re: [PATCH 13/14] sysfs: Simplify readdir.
teheo at suse.de
Tue Jul 31 04:36:08 PDT 2007
Eric W. Biederman wrote:
> At some point someone wrote sysfs_readdir to insert a cursor
> into the list of sysfs_dirents to ensure that sysfs_readdir would
> restart properly. That works but it is complex code and tends
> to be expensive.
> The same effect can be achived by keeping the sysfs_dirents in
> inode order and using the inode number as the f_pos. Then
> when we restart we just have to find the first dirent whose inode
> number is equal or greater then the last sysfs_dirent we attempted
> to return.
> Removing the sysfs directory cursor also allows the removal of
> all of the mysterious checks for sysfs_type(sd) != 0. Which
> were nonbovious checks to see if a cursor was in a directory list.
> Signed-off-by: Eric W. Biederman <ebiederm at xmission.com>
Great, Acked-by: Tejun Heo <htejun at gmail.com>
Containers mailing list
Containers at lists.linux-foundation.org
More information about the Devel