[Users] Problem with TCP window too large for TCPRCVBUF still present

Marcin Owsiany marcin at owsiany.pl
Thu Mar 20 10:15:25 EDT 2008


On Thu, Mar 20, 2008 at 04:19:19PM +0300, Vitaliy Gusev wrote:
> Try attached patch again, please.

Changing "struct tcp_opt" to "struct tcp_sock" fixed the compilation
issue, thanks.

I also noticed you added another call to ub_sock_tcp_update_rcvbuf(),
here:

> @@ -829,7 +870,9 @@ int ub_sock_tcp_chargerecv(struct sock *sk, struct sk_buff *skb,
>  	retval = 0;
>  	ub = top_beancounter(sock_bc(sk)->ub);
>  	spin_lock_irqsave(&ub->ub_lock, flags);
> +	ub_sock_tcp_update_rcvbuf(ub, sk);
>  	ub->ub_parms[UB_TCPRCVBUF].held += chargesize;
> +	ub_sock_tcp_update_rcvbuf(ub, sk);
>  	if (ub->ub_parms[UB_TCPRCVBUF].held >
>  			ub->ub_parms[UB_TCPRCVBUF].barrier &&
>  			strict != UB_FORCE)

I'm not predenting I understand what it's all about, but just wanted to
ask if you really wanted to add this, and it's not just some copy-paste
typo.

Anyway, switching to the newer openvz patch has changed the kernel ABI,
so it will take me a bit more time to sort my package builds and test
the new kernel. This email is just to let you know that it built
successfully.

-- 
Marcin Owsiany <marcin at owsiany.pl>              http://marcin.owsiany.pl/
GnuPG: 1024D/60F41216  FE67 DA2D 0ACA FC5E 3F75  D6F6 3A0D 8AA0 60F4 1216
 
"Every program in development at MIT expands until it can read mail."
                                                              -- Unknown


More information about the Users mailing list