<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:2029480708;
mso-list-type:hybrid;
mso-list-template-ids:1695435782 134807567 134807577 134807579 134807567 134807577 134807579 134807567 134807577 134807579;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-SG" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal" style="margin-left:36.0pt;text-indent:-18.0pt">Found 2 issues:<o:p></o:p></p>
<ol style="margin-top:0cm" start="1" type="1">
<li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1">It’s better to move fiemap_prep() before inode_lock, as it was the case before when same thing is done in ioctl_fiemap().
<o:p></o:p></li><li class="MsoListParagraph" style="margin-left:0cm;mso-list:l0 level1 lfo1">FIEMAP_FLAG_SYNC as the last parameter is unnecessary, because it is always checked in fiemap_prep().<o:p></o:p></li></ol>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-left:36.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Andrey Zaitsev <Andrey.Zaitsev@acronis.com><br>
<b>Date: </b>Monday, 16 October 2023 at 5:23 PM<br>
<b>To: </b>"Denis V. Lunev" <den@virtuozzo.com>, Alexey Kuznetsov <kuznet@virtuozzo.com>, Devel <devel@openvz.org>, "khorenko@virtuozzo.com" <khorenko@virtuozzo.com>, Kui Liu <Kui.Liu@acronis.com><br>
<b>Subject: </b>Re: fuse: call proper fiemap_prep as it is required by new kernel api<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"><o:p> </o:p></p>
</div>
<div>
<div id="x_divtagdefaultwrapper">
<p style="margin-left:36.0pt"><span style="font-size:12.0pt;color:black">ok for me<o:p></o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="margin-left:36.0pt;text-align:center">
<hr size="0" width="93%" align="center">
</div>
<div id="x_divRplyFwdMsg">
<p class="MsoNormal" style="margin-left:36.0pt"><b><span style="color:black">From:</span></b><span style="color:black"> Denis V. Lunev <den@virtuozzo.com><br>
<b>Sent:</b> Sunday, October 15, 2023 10:08:40 PM<br>
<b>To:</b> Alexey Kuznetsov; Devel; khorenko@virtuozzo.com; Andrey Zaitsev; Kui Liu<br>
<b>Subject:</b> Re: fuse: call proper fiemap_prep as it is required by new kernel api</span>
<o:p></o:p></p>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"> <o:p></o:p></p>
</div>
</div>
</div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:10.0pt">On 10/13/23 20:35, Alexey Kuznetsov wrote:<br>
> Otherwise we consider locations with dirty page cache as holes.<br>
><br>
> Affects: #VSTOR-76073, #PSBM-151414, #PSBM-151424, #PSBM-151464<br>
><br>
> Signed-off-by: Alexey Kuznetsov <kuznet@acronis.com><br>
> ---<br>
> fs/fuse/file.c | 4 ++++<br>
> 1 file changed, 4 insertions(+)<br>
><br>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c<br>
> index 5e23bd5..c685e01 100644<br>
> --- a/fs/fuse/file.c<br>
> +++ b/fs/fuse/file.c<br>
> @@ -3711,6 +3711,10 @@ int fuse_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,<br>
> <br>
> inode_lock(inode);<br>
> <br>
> + err = fiemap_prep(inode, fieinfo, start, &len, FIEMAP_FLAG_SYNC);<br>
> + if (err)<br>
> + goto out;<br>
> +<br>
> fuse_sync_writes(inode);<br>
> fuse_read_dio_wait(fi);<br>
> <br>
Can we get acknowledgement for this patch in order to<br>
start merge/build ASAP?<br>
<br>
Thanks you in advance,<br>
Den<o:p></o:p></span></p>
</div>
</div>
</body>
</html>