<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<div dir="auto">It was me.
<div dir="auto">The reason is explained in the patch description (you can find more details in description of the commit, introduced the hook).</div>
<div dir="auto">I'm waiting for khorenko@ to convince him, that the idea to "podkovat' blohy" was wrong by design and we should drop the hook.</div>
<div dir="auto">Once I succeed, I'll sent appropriate series to get rid of it completely.</div>
<div dir="auto">So this patch is temporary one, because too many tests have failed because of this race.</div>
<div dir="auto"><br>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">2 окт. 2017 г. 8:05 PM пользователь Andrey Vagin <avagin@virtuozzo.com> написал:<br type="attribution">
<blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><font size="2"><span style="font-size:10pt">
<div>On Mon, Oct 02, 2017 at 06:47:19PM +0400, Stanislav Kinsburskiy wrote:<br>
> This hook is needed only for releaseing venet IP address early (thus allowing<br>
> to restart container with the same IP faster).<br>
> But mount are destroyed asynchroniosly, and thus NFS mount can be destroyed<br>
> after IP address is dropped.<br>
> Let's fir this race it the way how all the world does things: release IP with<br>
> network namespace.<br>
<br>
Why don't you remove this code? Who added this hook? What was a reason?<br>
<br>
> <br>
> <a href="https://jira.sw.ru/browse/PSBM-73193">https://jira.sw.ru/browse/PSBM-73193</a><br>
> <br>
> Signed-off-by: Stanislav Kinsburskiy <skinsbursky@virtuozzo.com><br>
> ---<br>
> kernel/ve/ve.c | 3 ++-<br>
> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
> <br>
> diff --git a/kernel/ve/ve.c b/kernel/ve/ve.c<br>
> index b0188c3..4efb9d9 100644<br>
> --- a/kernel/ve/ve.c<br>
> +++ b/kernel/ve/ve.c<br>
> @@ -451,7 +451,8 @@ static void ve_drop_context(struct ve_struct *ve)<br>
> synchronize_rcu();<br>
> put_nsproxy(ve_ns);<br>
> <br>
> - ve_hook_iterate_fini(VE_SHUTDOWN_CHAIN, ve);<br>
> + /* This have to be revisited */<br>
> +// ve_hook_iterate_fini(VE_SHUTDOWN_CHAIN, ve);<br>
> <br>
> put_cred(ve->init_cred);<br>
> ve->init_cred = NULL;<br>
> <br>
> _______________________________________________<br>
> Devel mailing list<br>
> Devel@openvz.org<br>
> <a href="https://lists.openvz.org/mailman/listinfo/devel">https://lists.openvz.org/mailman/listinfo/devel</a><br>
</div>
</span></font></div>
</blockquote>
</div>
<br>
</div>
</body>
</html>