[Devel] [PATCH vz10 12/15] selftests/netfilter: remove unused variables in conntrack_dump_flush

[Vasileios Almpanis]

Reviewed-by: Vasileios Almpanis <vasileios.almpanis at virtuozzo.com>

On 3/23/26 9:31 PM, Konstantin Khorenko wrote:
>    conntrack_dump_flush.c: In function 'conntrack_data_insert':
>    conntrack_dump_flush.c:105:26: warning: unused variable 'rplnlh' [-Wunused-variable]
>      105 |         struct nlmsghdr *rplnlh;
>          |                          ^~~~~~
>    conntrack_dump_flush.c: In function 'conntracK_count_zone':
>    conntrack_dump_flush.c:224:24: warning: unused variable 'nest' [-Wunused-variable]
>      224 |         struct nlattr *nest;
>          |                        ^~~~
>    conntrack_dump_flush.c:222:32: warning: unused variable 'rplnlh' [-Wunused-variable]
>      222 |         struct nlmsghdr *nlh, *rplnlh;
>          |                                ^~~~~~
>    conntrack_dump_flush.c: In function 'conntrack_flush_zone':
>    conntrack_dump_flush.c:271:24: warning: unused variable 'nest' [-Wunused-variable]
>      271 |         struct nlattr *nest;
>          |                        ^~~~
>    conntrack_dump_flush.c:269:32: warning: unused variable 'rplnlh' [-Wunused-variable]
>      269 |         struct nlmsghdr *nlh, *rplnlh;
>          |                                ^~~~~~
>
> Remove unused 'rplnlh' and 'nest' variables from conntrack_data_insert(),
> conntracK_count_zone() and conntrack_flush_zone() to fix -Wunused-variable
> warnings.
>
> https://virtuozzo.atlassian.net/browse/VSTOR-127529
> Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
>
> Feature: fix selftests
> ---
>   .../testing/selftests/net/netfilter/conntrack_dump_flush.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
> index 5f827e10717d..5ecbcb272edf 100644
> --- a/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
> +++ b/tools/testing/selftests/net/netfilter/conntrack_dump_flush.c
> @@ -102,7 +102,6 @@ static int conntrack_data_insert(struct mnl_socket *sock, struct nlmsghdr *nlh,
>   				 uint16_t zone)
>   {
>   	char buf[MNL_SOCKET_BUFFER_SIZE];
> -	struct nlmsghdr *rplnlh;
>   	unsigned int portid;
>   	int ret;
>   
> @@ -219,9 +218,8 @@ static int count_entries(const struct nlmsghdr *nlh, void *data)
>   static int conntracK_count_zone(struct mnl_socket *sock, uint16_t zone)
>   {
>   	char buf[MNL_SOCKET_BUFFER_SIZE];
> -	struct nlmsghdr *nlh, *rplnlh;
> +	struct nlmsghdr *nlh;
>   	struct nfgenmsg *nfh;
> -	struct nlattr *nest;
>   	unsigned int portid;
>   	int ret;
>   
> @@ -266,9 +264,8 @@ static int conntracK_count_zone(struct mnl_socket *sock, uint16_t zone)
>   static int conntrack_flush_zone(struct mnl_socket *sock, uint16_t zone)
>   {
>   	char buf[MNL_SOCKET_BUFFER_SIZE];
> -	struct nlmsghdr *nlh, *rplnlh;
> +	struct nlmsghdr *nlh;
>   	struct nfgenmsg *nfh;
> -	struct nlattr *nest;
>   	unsigned int portid;
>   	int ret;
>