[Devel] [PATCH vz10 3/6] ms/selftests/mm: fix -Wmaybe-uninitialized warnings

[Vasileios Almpanis]

Reviewed-by: Vasileios Almpanis <vasileios.almpanis at virtuozzo.com>

On 3/23/26 9:29 PM, Konstantin Khorenko wrote:
> From: Kevin Brodsky <kevin.brodsky at arm.com>
>
> A few -Wmaybe-uninitialized warnings show up when building the mm tests
> with -O2.  None of them looks worrying; silence them by initialising the
> problematic variables.
>
> Link: https://lkml.kernel.org/r/20241209095019.1732120-3-kevin.brodsky@arm.com
> Signed-off-by: Kevin Brodsky <kevin.brodsky at arm.com>
> Cc: Aruna Ramakrishna <aruna.ramakrishna at oracle.com>
> Cc: Catalin Marinas <catalin.marinas at arm.com>
> Cc: Dave Hansen <dave.hansen at linux.intel.com>
> Cc: Joey Gouly <joey.gouly at arm.com>
> Cc: Keith Lucas <keith.lucas at oracle.com>
> Cc: Ryan Roberts <ryan.roberts at arm.com>
> Cc: Shuah Khan <shuah at kernel.org>
> Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
>
> (cherry picked from commit 516fb516383ef39d881d116c6447826356883ad0)
> Applied cleanly (minor context adjustment in uffd-unit-tests.c).
>
> https://virtuozzo.atlassian.net/browse/VSTOR-127529
> Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
>
> Feature: fix selftests
> ---
>   tools/testing/selftests/mm/ksm_tests.c       | 2 +-
>   tools/testing/selftests/mm/mremap_test.c     | 2 +-
>   tools/testing/selftests/mm/soft-dirty.c      | 2 +-
>   tools/testing/selftests/mm/uffd-unit-tests.c | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/ksm_tests.c b/tools/testing/selftests/mm/ksm_tests.c
> index b748c48908d9..dcdd5bb20f3d 100644
> --- a/tools/testing/selftests/mm/ksm_tests.c
> +++ b/tools/testing/selftests/mm/ksm_tests.c
> @@ -776,7 +776,7 @@ static int ksm_cow_time(int merge_type, int mapping, int prot, int timeout, size
>   
>   int main(int argc, char *argv[])
>   {
> -	int ret, opt;
> +	int ret = 0, opt;
>   	int prot = 0;
>   	int ksm_scan_limit_sec = KSM_SCAN_LIMIT_SEC_DEFAULT;
>   	int merge_type = KSM_MERGE_TYPE_DEFAULT;
> diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c
> index d207a52f2b5b..bb84476a177f 100644
> --- a/tools/testing/selftests/mm/mremap_test.c
> +++ b/tools/testing/selftests/mm/mremap_test.c
> @@ -384,7 +384,7 @@ static void mremap_move_within_range(unsigned int pattern_seed, char *rand_addr)
>   static long long remap_region(struct config c, unsigned int threshold_mb,
>   			      char *rand_addr)
>   {
> -	void *addr, *src_addr, *dest_addr, *dest_preamble_addr;
> +	void *addr, *src_addr, *dest_addr, *dest_preamble_addr = NULL;
>   	unsigned long long t, d;
>   	struct timespec t_start = {0, 0}, t_end = {0, 0};
>   	long long  start_ns, end_ns, align_mask, ret, offset;
> diff --git a/tools/testing/selftests/mm/soft-dirty.c b/tools/testing/selftests/mm/soft-dirty.c
> index bdfa5d085f00..8e1462ce0532 100644
> --- a/tools/testing/selftests/mm/soft-dirty.c
> +++ b/tools/testing/selftests/mm/soft-dirty.c
> @@ -128,7 +128,7 @@ static void test_mprotect(int pagemap_fd, int pagesize, bool anon)
>   {
>   	const char *type[] = {"file", "anon"};
>   	const char *fname = "./soft-dirty-test-file";
> -	int test_fd;
> +	int test_fd = 0;
>   	char *map;
>   
>   	if (anon) {
> diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c
> index a2e71b1636e7..795bba310151 100644
> --- a/tools/testing/selftests/mm/uffd-unit-tests.c
> +++ b/tools/testing/selftests/mm/uffd-unit-tests.c
> @@ -1122,7 +1122,7 @@ uffd_move_test_common(uffd_test_args_t *targs, unsigned long chunk_size,
>   	char c;
>   	unsigned long long count;
>   	struct uffd_args args = { 0 };
> -	char *orig_area_src, *orig_area_dst;
> +	char *orig_area_src = NULL, *orig_area_dst = NULL;
>   	unsigned long step_size, step_count;
>   	unsigned long src_offs = 0;
>   	unsigned long dst_offs = 0;