[Devel] [PATCH VZ10] fs/fuse: force offload of final fput in aio completion to workqueue
Pavel Tikhomirov
ptikhomirov at virtuozzo.com
Fri Jun 26 15:42:46 MSK 2026
Not sure why the difference, maybe different config or something.
Here is my fixup https://bitbucket.org/virtuozzocore/vzkernel.vzs/commits/ee65c40a0ba4c9a284cbea94e689070e29abafae
after which build passes on the buildenv.
On 6/26/26 13:26, Alexey Kuznetsov wrote:
> Accepted. But I do not understand why. :-) It compiles for me...
> How did you repair this?
>
> On Fri, Jun 26, 2026 at 4:41 PM Pavel Tikhomirov
> <ptikhomirov at virtuozzo.com> wrote:
>>
>> On 6/25/26 13:12, Alexey Kuznetsov wrote:
>>> On Thu, Jun 25, 2026 at 5:41 PM Pavel Tikhomirov
>>> <ptikhomirov at virtuozzo.com> wrote:
>>>
>>>> nit: Is there a related jira issue?
>>>
>>> https://virtuozzo.atlassian.net/browse/VSTOR-135017
>>>
>>>> nit: https://docs.kernel.org/process/coding-style.html#commenting
>>>
>>> 1. The text is not mine. It is preserved from original patch.
>>> 2. Could not care less. :-) This "requirement" is just idiotic
>>
>> jfyi: does not compile
>>
>> fs/fuse/file.c: In function ‘fuse_aio_complete’:
>> fs/fuse/file.c:1009:17: error: implicit declaration of function ‘fput’; did you mean ‘iput’? [-Wimplicit-function-declaration]
>> 1009 | fput(file);
>> | ^~~~
>> | iput
>> make[4]: *** [scripts/Makefile.build:229: fs/fuse/file.o] Error 1
>> make[4]: *** Waiting for unfinished jobs....
>> make[3]: *** [scripts/Makefile.build:478: fs/fuse] Error 2
>> make[3]: *** Waiting for unfinished jobs....
>> make[2]: *** [scripts/Makefile.build:478: fs] Error 2
>> make[2]: *** Waiting for unfinished jobs....
>> make[1]: *** [/builddir/build/BUILD/kernel-6.12.0-211.16.1.el10_2/linux-6.12.0-211.16.1.12.6.vz10.x86_64/Makefile:2015: .] Error 2
>> make: *** [Makefile:247: __sub-make] Error 2
>>
>> --
>> Best regards, Pavel Tikhomirov
>> Senior Software Developer, Virtuozzo.
--
Best regards, Pavel Tikhomirov
Senior Software Developer, Virtuozzo.
More information about the Devel
mailing list