[Devel] [PATCH VZ10 0/7] vhost-blk: assortment of fixes

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Mon Jun 15 19:59:04 MSK 2026


Reviewed-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>

On 6/15/26 16:55, Andrey Zhadchenko wrote:
> This series mainly addresses the handling of failing requests.
> Previously the driver will always retry all requests failed at
> processing and will always complete the requests if they are
> past bio submission point.
> 
> Using vhost-net and vhost-scsi as a model, we adopt the following
> approach:
>  - requests failed at processing phase with ENOMEM/EAGAIN are re-tried
>  - requests failed at processing phase with other errors are not
> reported completed and are not processed further. It is higly likely
> they are just incorrect
>  - requests failed at status write after the completion are not
> reported completed
> 
> This may sometime lead to guests stalling, but the alternatives are
> always worse.
> 
> Also the patchset improves logging and adds a few sanity checks.
> https://virtuozzo.atlassian.net/browse/VSTOR-134034
> 
> Andrey Zhadchenko (7):
>   drivers/vhost/blk: fix uninitialized variable
>   drivers/vhost/blk: better log errors in vhost-blk
>   drivers/vhost/blk: improve request re-processing
>   drivers/vhost/blk: improve vhostblk_vq_err() usage
>   drivers/vhost/blk: do not complete requests with failed status write
>   drivers/vhost/blk: fail request instead of BUG_ON()
>   drivers/vhost/blk: ensure total request size
> 
>  drivers/vhost/blk.c | 50 +++++++++++++++++++++++++++++++--------------
>  1 file changed, 35 insertions(+), 15 deletions(-)
> 

-- 
Best regards, Pavel Tikhomirov
Senior Software Developer, Virtuozzo.



More information about the Devel mailing list