[Devel] [PATCH RHEL10 COMMIT] selftests: net: l2tp: ensure required modules are loaded

[Konstantin Khorenko]

--
Best regards,

Konstantin Khorenko,
Virtuozzo Linux Kernel Team

On 1/9/26 16:44, Konstantin Khorenko wrote:
> Nope, i have dropped this patch for now.
> 
> So you state that those modules were not loaded automatically and the test must preload them.
> At the same time those modules are loaded automatically in VHP env.
> 
> So what is the difference? Why in HCI 7.3 modules were not loaded automatically?
> We definitely need to understand this because that might cause issues with other userspace in case
> modules are not being loaded automatically due to some reason.
> 
> On 1/9/26 16:15, Konstantin Khorenko wrote:
>> The commit is pushed to "branch-rh10-6.12.0-55.13.1.2.x.vz10-ovz" and will appear at git at bitbucket.org:openvz/vzkernel.git
>> after rh10-6.12.0-55.13.1.2.29.vz10
>> ------>
>> commit c969e337262e0aa5fe25e64a37f62b74d8b4e6d6
>> Author: Aleksei Oladko <aleksey.oladko at virtuozzo.com>
>> Date:   Sun Jan 4 01:50:26 2026 +0000
>>
>>       selftests: net: l2tp: ensure required modules are loaded
>>       
>>       The net kselftest l2tp.sh fails when the required l2tp kernel modules
>>       are not loaded beforehand.
>>       
>>       Explicitly load the necessary l2tp modules via modprobe before running
>>       the test, so that l2tp.sh does not depend on the module autoloading
>>       behaviour of the system.
>>       
>>       https://virtuozzo.atlassian.net/browse/VSTOR-121804
>>       
>>       Signed-off-by: Aleksei Oladko <aleksey.oladko at virtuozzo.com>
>>       
>>       Feature: fix selftests
>> ---
>>    tools/testing/selftests/net/l2tp.sh | 3 +++
>>    1 file changed, 3 insertions(+)
>>
>> diff --git a/tools/testing/selftests/net/l2tp.sh b/tools/testing/selftests/net/l2tp.sh
>> index 88de7166c8ae9..0927056b92689 100755
>> --- a/tools/testing/selftests/net/l2tp.sh
>> +++ b/tools/testing/selftests/net/l2tp.sh
>> @@ -369,6 +369,9 @@ do
>>    	esac
>>    done
>>    
>> +modprobe l2tp_eth || exit $ksft_skip
>> +modprobe l2tp_ip6 || exit $ksft_skip

And BTW, if we have some problems and modules failed to load, why do we consider this OK and just skip 
the test?

i think - it's a problem if those modules fail to load, and this should be caught be the kselftest and 
investigated and fixed.

>> +
>>    run_tests
>>    cleanup
>>    
>