[Devel] [PATCH vz10 v2] selftests: netdevsim: mark ethtool-features.sh executable
Konstantin Khorenko
khorenko at virtuozzo.com
Mon Aug 24 17:35:28 MSK 2026
From: Eva Kurchatova <eva.kurchatova at virtuozzo.com>
The script is listed in TEST_PROGS but, unlike its 14 siblings there,
is not executable. Nothing actually fails: run_kselftest.sh falls back
to running a non-executable test through the interpreter from its
shebang, so the only effect is
# Warning: file ethtool-features.sh is not executable
in the log. Still, the warning reads like a problem, kernel packaging
installs the script 0644 where every other test in the directory is
0755, and running it by hand needs an explicit interpreter.
Set the bit.
https://virtuozzo.atlassian.net/browse/VSTOR-139651
Feature: fix selftests
Signed-off-by: Eva Kurchatova <eva.kurchatova at virtuozzo.com>
Reviewed-by: Konstantin Khorenko <khorenko at virtuozzo.com>
---
Changes in v2:
- commit message only, the mode change itself is unchanged. v1 said
the runner cannot start the script, which is not true: for a test
that is not executable run_kselftest.sh falls back to the interpreter
from its shebang, so nothing fails today. Say what the patch really
buys instead.
tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh
diff --git a/tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh b/tools/testing/selftests/drivers/net/netdevsim/ethtool-features.sh
old mode 100644
new mode 100755
--
2.47.1
More information about the Devel
mailing list