[Devel] [PATCH VZ9 2/2] fs/fuse/kio: remove aligned-inside-packed kludge

[Alexey Kuznetsov]

Hello!

On Wed, Oct 22, 2025 at 7:26 PM Pavel Tikhomirov
<ptikhomirov at virtuozzo.com> wrote:
> I see that we still use __pre_aligned() and __pre_packed in other places
> but they are defined like:
...
> So my question is, do they actually do/did something? At least now they
> seem empty.

They are empty for gcc. Yes, these defines are also inherited from
user space, but they are used in protocol definitions.
So, they should stay because we share these defintions with user
space, which uses them with non-gcc, even with windows
(unfortunately).

But they are absolute no for internal kernel structures like pcs_msg.


> "pool" seems completely removed, is it intentional? Is it an unused field?

Yes. It also was copypasted from user space at day zero, but does not make sense
in kernel. At least for now.

I noticed it when searchin for bug fixed in patch 1 of the series. I
could not remove
it or change sick struct alignment before the bug is fixed.