[Devel] [PATCH VZ10 5/5] ve/printk: switch to ve_netdev_info() helper for network device information printing

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Tue Oct 7 11:50:29 MSK 2025


This was originally netdev_info(), but we didn't have corresponding
ve_netdev_info() hepler at the time of RH10 rebase, so it was temporarly
replaced by ve_printk(). Now we can switch to ve_netdev_info().

Actual change e.g. for a veth device is kinda subtle:

Before:
device veth72818071 entered promiscuous mode

After:
veth72818071: entered promiscuous mode

But now we properly follow original __netdev_printk() format for all
possible cases.

Fixes: c3d2bd4b6946f ("ve: Use ve_printk() for often kernel messages about user actions")
https://virtuozzo.atlassian.net/browse/VSTOR-106826
Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
---
 net/core/dev.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 2adeff25fb9a6..9bde69ad3c487 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -8652,9 +8652,9 @@ static int __dev_set_promiscuity(struct net_device *dev, int inc, bool notify)
 		WRITE_ONCE(dev->flags, flags);
 
 		if (!(flags & (IFF_LOOPBACK | IFF_POINTOPOINT))) {
-			ve_printk(VE_LOG, KERN_INFO "device %s %s promiscuous mode\n",
-				  dev->name,
-				  dev->flags & IFF_PROMISC ? "entered" : "left");
+			ve_netdev_info(VE_LOG, dev, "%s promiscuous mode\n",
+				       dev->flags & IFF_PROMISC ?
+				       "entered" : "left");
 			if (audit_enabled) {
 				current_uid_gid(&uid, &gid);
 				audit_log(audit_context(), GFP_ATOMIC,
-- 
2.51.0



More information about the Devel mailing list