[Devel] [PATCH vz9] dm-ploop: remove redundant wakeup of dispatcher_wq_prealloc

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Wed Jul 9 05:05:35 MSK 2025


Reviewed-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>

On 7/8/25 19:38, Konstantin Khorenko wrote:
> The wakeup exists in the function caller - in ploop_allocator().
> 
> Found while working on
> https://virtuozzo.atlassian.net/browse/VSTOR-108868
> 
> Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
> 
> Feature: dm-ploop: ploop target driver
> ---
>   drivers/md/dm-ploop-map.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c
> index fcc10894411ca..cbac93194c344 100644
> --- a/drivers/md/dm-ploop-map.c
> +++ b/drivers/md/dm-ploop-map.c
> @@ -1216,9 +1216,6 @@ static int ploop_preallocate_cluster(struct ploop *ploop, struct file *file)
>   	ploop->prealloc_size = 0;
>   	spin_unlock_irqrestore(&ploop->bat_lock, flags);
>   
> -	/* notify if someone is waiting */
> -	wake_up_interruptible(&ploop->dispatcher_wq_prealloc);
> -
>   	return ret;
>   }
>   ALLOW_ERROR_INJECTION(ploop_preallocate_cluster, ERRNO);

-- 
Best regards, Pavel Tikhomirov
Senior Software Developer, Virtuozzo.



More information about the Devel mailing list