[Devel] [PATCH v5 vz9 3/7] dm-ploop: drop old_size variable in ploop_allocate_cluster()

Konstantin Khorenko khorenko at virtuozzo.com
Mon Jul 7 22:47:57 MSK 2025


From: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>

Redundant variable.

https://virtuozzo.atlassian.net/browse/VSTOR-108868
Co-developed-by: Andrey Zhadchenko <andrey.zhadchenko at virtuozzo.com>
Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>

Feature: dm-ploop: ploop target driver
---
 drivers/md/dm-ploop-map.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c
index f7e443a589548..f7bb6bcf13feb 100644
--- a/drivers/md/dm-ploop-map.c
+++ b/drivers/md/dm-ploop-map.c
@@ -1259,7 +1259,7 @@ static int ploop_allocate_cluster(struct ploop *ploop, u32 *dst_clu, struct file
 {
 	struct ploop_delta *top = ploop_top_delta(ploop);
 	u32 clu_size = CLU_SIZE(ploop);
-	loff_t off, pos, end, old_size;
+	loff_t off, pos, end;
 	unsigned long flags;
 	int ret;
 	int retry_cnt = 0;
@@ -1278,11 +1278,10 @@ static int ploop_allocate_cluster(struct ploop *ploop, u32 *dst_clu, struct file
 	 */
 	ploop_hole_clear_bit(*dst_clu, ploop);
 
-	old_size = top->file_size;
 	prealloc_start = top->file_preallocated_area_start;
 	pos = CLU_TO_POS(ploop, *dst_clu);
 	end = pos + clu_size;
-	off = min_t(loff_t, old_size, end);
+	off = min_t(loff_t, top->file_size, end);
 	spin_unlock_irqrestore(&ploop->bat_lock, flags);
 
 	if (pos < prealloc_start) {
@@ -1316,8 +1315,7 @@ static int ploop_allocate_cluster(struct ploop *ploop, u32 *dst_clu, struct file
 retry_alloc:
 	spin_lock_irqsave(&ploop->bat_lock, flags);
 	/* size can change from parallel alloc */
-	old_size = top->file_size;
-	if (end > old_size) {
+	if (end > top->file_size) {
 		ploop_req_prealloc(ploop, PREALLOC_SIZE);
 		spin_unlock_irqrestore(&ploop->bat_lock, flags);
 
-- 
2.43.0



More information about the Devel mailing list