[Devel] [PATCH VZ9 v2 2/2] drivers/md/ploop: drop unused arguments

Andrey Zhadchenko andrey.zhadchenko at virtuozzo.com
Fri Jul 4 13:24:21 MSK 2025


in ploop_should_prealloc() and ploop_truncate_prealloc_safe()

https://virtuozzo.atlassian.net/browse/VSTOR-108868
Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko at virtuozzo.com>
---
 drivers/md/dm-ploop-map.c    | 5 ++---
 drivers/md/dm-ploop-target.c | 2 +-
 drivers/md/dm-ploop.h        | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c
index 089731bc7e3a..e4d673708bbf 100644
--- a/drivers/md/dm-ploop-map.c
+++ b/drivers/md/dm-ploop-map.c
@@ -1131,7 +1131,6 @@ static int ploop_find_dst_clu_bit(struct ploop *ploop, u32 *ret_dst_clu)
 ALLOW_ERROR_INJECTION(ploop_find_dst_clu_bit, ERRNO);
 
 static int ploop_truncate_prealloc_safe(struct ploop *ploop,
-					struct ploop_delta *delta,
 					loff_t old_len, loff_t new_len, struct file *file,
 					const char *func)
 {
@@ -1188,7 +1187,7 @@ static int ploop_preallocate_cluster(struct ploop *ploop, struct file *file)
 	if (!prealloc_size)
 		return 0;
 
-	ret = ploop_truncate_prealloc_safe(ploop, top, top->file_size,
+	ret = ploop_truncate_prealloc_safe(ploop, top->file_size,
 					   new_len, file, __func__);
 	if (ret)
 		PL_ERR("Failed to preallocate space: %d\n", ret);
@@ -1219,7 +1218,7 @@ static int ploop_preallocate_cluster(struct ploop *ploop, struct file *file)
 }
 ALLOW_ERROR_INJECTION(ploop_preallocate_cluster, ERRNO);
 
-void ploop_should_prealloc(struct ploop *ploop, struct file *file)
+void ploop_should_prealloc(struct ploop *ploop)
 {
 	struct ploop_delta *top = ploop_top_delta(ploop);
 	u32 dst_clu;
diff --git a/drivers/md/dm-ploop-target.c b/drivers/md/dm-ploop-target.c
index aa1379088a80..525e8d7ceb1f 100644
--- a/drivers/md/dm-ploop-target.c
+++ b/drivers/md/dm-ploop-target.c
@@ -608,7 +608,7 @@ static int ploop_ctr(struct dm_target *ti, unsigned int argc, char **argv)
 	ti->discards_supported = true;
 
 	if (ploop->nr_deltas > 0)
-		ploop_should_prealloc(ploop, ploop_top_delta(ploop)->file);
+		ploop_should_prealloc(ploop);
 
 	return 0;
 
diff --git a/drivers/md/dm-ploop.h b/drivers/md/dm-ploop.h
index ec3f2ffdf2b1..72cc38bbe931 100644
--- a/drivers/md/dm-ploop.h
+++ b/drivers/md/dm-ploop.h
@@ -645,7 +645,7 @@ extern int ploop_allocator(void *data);
 extern void ploop_disable_writeback_delay(struct ploop *ploop);
 extern void ploop_enable_writeback_delay(struct ploop *ploop);
 
-extern void ploop_should_prealloc(struct ploop *ploop, struct file *file);
+extern void ploop_should_prealloc(struct ploop *ploop);
 extern void ploop_resubmit_enospc_pios(struct ploop *ploop);
 
 #endif /* __DM_PLOOP_H */
-- 
2.43.5



More information about the Devel mailing list