[Devel] [PATCH VZ9 v3 0/5] blk-cbt improvements

[Pavel Tikhomirov]

Reviewed-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>

On 1/28/25 16:15, Andrey Zhadchenko wrote:
> Currently blk-cbt use UUID as a name. This is a big limitation.
> We are going to expose bitmap names to libvirt, so we should
> not expect users to follow this. Moreover, even VHI backup
> utilities use non-UUID names sometimes. Technically QEMU
> allows us bitmap names up to 1024 bytes, but 128 should be
> fine.
> Multiple simultaneous bitmaps are needed for backup plans,
> so allow them.
> Add new API to list bitmap names, adjust most of the API to
> make operations on bitmap with user-provided name.
> 
> v2:
>   - add "blk-cbt: introduce ABI versioning" patch
>   - add "block/blk-cbt: add BLKCBTRENAME instead of BLKCBTSET flag"
> patch
>   - remove total_count from blk_user_cbt_list()
>   - add cbt limit
>   - various suggestions and small fixes for patch
> "block/blk-cbt: allow multiple cbts in a single queue"
> 
> v3:
>   - call all copy_from_user() before taking mutex_lock
> 
> Andrey Zhadchenko (5):
>    block/blk-cbt: rework uuid field
>    block/blk-cbt: allow multiple cbts in a single queue
>    blk-cbt: introduce ABI versioning
>    block/blk-cbt: add BLKCBTLIST ioctl
>    block/blk-cbt: add BLKCBTRENAME instead of BLKCBTSET flag
> 
>   block/blk-cbt.c         | 288 +++++++++++++++++++++++++++-------------
>   block/blk-core.c        |   2 +
>   block/ioctl.c           |   2 +
>   include/linux/blkdev.h  |   2 +-
>   include/uapi/linux/fs.h |  24 +++-
>   5 files changed, 218 insertions(+), 100 deletions(-)
> 

-- 
Best regards, Tikhomirov Pavel
Senior Software Developer, Virtuozzo.