[Devel] [PATCH vz9 v2 13/65] dm-ploop: move preparations of pios into the caller from worker

[Pavel Tikhomirov]

On 2/12/25 17:33, Konstantin Khorenko wrote:
> @@ -325,17 +322,24 @@ static int ploop_split_pio_to_list(struct ploop *ploop, struct pio *pio,
>   		if (!split)
>   			goto err;
>   
> -		list_add_tail(&split->list, &list);
> +		llist_add(&split->llist, &llist);
>   	}
>   
> -	list_splice_tail(&list, ret_list);
> -	list_add_tail(&pio->list, ret_list);
> +	pio->llist.next = NULL;

The above line looks excess. The llist_add below will set 
pio->llist.next anyway, so no need to set NULL there.

> +	llist_add(&pio->llist, &llist);
> +	lltmp = llist_reverse_order(llist_del_all(&llist));
> +	pio->llist.next = NULL;
> +	llist_add_batch(lltmp, &pio->llist, ret_llist);
> +
>   	return 0;
>   err:

-- 
Best regards, Tikhomirov Pavel
Senior Software Developer, Virtuozzo.