[Devel] [PATCH vz9 v1 55/63] dm-ploop: rework bat completion logic

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Mon Feb 10 06:21:43 MSK 2025


On 1/24/25 23:36, Alexander Atanasov wrote:
> @@ -900,6 +902,7 @@ static void ploop_advance_local_after_bat_wb(struct ploop *ploop,
>   	if (wait_llist_pending) {
>   		llist_for_each_safe(pos, t, wait_llist_pending) {
>   			pio = list_entry((struct list_head *)pos, typeof(*pio), list);
> +			INIT_LIST_HEAD(&pio->list);
>   			list_add(&pio->list, &list);
>   		}
>   	}

Excess list initialization. There is no point in initializing the 
list_head before inserting it into list. Please fix it in all other 
places, not just this one.

-- 
Best regards, Tikhomirov Pavel
Senior Software Developer, Virtuozzo.



More information about the Devel mailing list