[Devel] [PATCH vz9 v1 08/63] dm-ploop: convert the rest of the lists to use llist variant

Alexander Atanasov alexander.atanasov at virtuozzo.com
Mon Feb 3 09:50:49 MSK 2025


On 31.01.25 10:32, Pavel Tikhomirov wrote:
> 
> 
> On 1/24/25 23:35, Alexander Atanasov wrote:
>> @@ -353,23 +352,20 @@ static void ploop_dispatch_pio(struct ploop 
>> *ploop, struct pio *pio,
>>       else
>>           *is_data = true;
>> -    list_add_tail(&pio->list, list);
>> +    llist_add((struct llist_node *)(&pio->list), list);
>>   }
> 
> I still believe that proper enum should be added to pio structure, so 
> that we have separate pio->llist for llist operations and pio->list for 
> list operations.
> 

i'd rather check if any list usages are left and change the type which 
was the initial goal.
The union /i beleive enum is a lapsus/ didn't worked due to static type 
checking in list macros.

-- 
Regards,
Alexander Atanasov



More information about the Devel mailing list