[Devel] [PATCH vz10] cgroup-v2: Clarify ve0 cgroup handling in hidden_ss_mask

[Pavel Tikhomirov]

On 12/12/25 21:52, Konstantin Khorenko wrote:
> Add comment explaining that ve0 cgroup files remain shown if ve0 is
> the root cgroup, as root cgroup is not created through cgroup_create().
> This clarifies the behavior mentioned in the commit message.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-119803
> Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
> ---
>  kernel/cgroup/cgroup.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 4274097b65f9c..291dcbae79609 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -6452,6 +6452,10 @@ static struct cgroup *cgroup_create(struct cgroup *parent, const char *name,
>  	if (!cgroup_on_dfl(cgrp))
>  		cgrp->subtree_control = cgroup_control(cgrp);
>  	else
> +		/* Hide ve controller by default. Note that ve0 cgroup files

You use network multiline comment style in general code, should be:

/*
 * Multiline
 * comment.
 */

As for the comment itself, thanks, that helps understanding code a lot, Looks good.

Reviewed-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>

> +		 * remain shown if ve0 is the root cgroup, as root cgroup is
> +		 * not created through cgroup_create().
> +		 */
>  		cgrp->hidden_ss_mask = 1 << ve_cgrp_id;
>  
>  	cgroup_propagate_control(cgrp);

-- 
Best regards, Pavel Tikhomirov
Senior Software Developer, Virtuozzo.