[Devel] [PATCH VZ9] configs: Enable PSI pressure monitoring by default for cgroup v2

Denis V. Lunev den at virtuozzo.com
Tue Sep 24 14:26:13 MSK 2024


In general I do not like this approach.

1. If we set our parameters in kernel configs, we introduce
    a lot of problems. We should specifically check upgrade
    path and clean installation path.
2. We also make further upgrade more complex if once we would
    decide that the default is to be changed.

We have eaten enough of this crap specifically with cgroup v2
switch.

I think that the decision about this patch should be
re-discussed and the patch should be accepted.

Kostya, please take this into the account as you have
to rebuild 72.x kernel.

Den


On 9/18/24 15:12, Konstantin Khorenko wrote:
> As we really want our product(s) are able to run on stock kernels, 
> it’s much better to enable PSI via kernel boot option rather than 
> recompile the kernel.
> This way will work for stock kernel as well.
>
> => i will not apply kernel patch, please, file a task and use kernel 
> boot option.
>
> -- 
> Best regards,
>
> Konstantin Khorenko,
> Virtuozzo Linux Kernel Team
>
> On 18.09.2024 11:20, Pavel Tikhomirov wrote:
>> We need this in vcmmd cgroup-v2 to get events about high memory
>> pressure.
>>
>> https://virtuozzo.atlassian.net/browse/VSTOR-92223
>> Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
>>
>> Feature: cgroup: unified cgroup hierarchy (cgroup v2) support
>> ---
>>   configs/kernel-5.14.0-x86_64-debug.config | 2 +-
>>   configs/kernel-5.14.0-x86_64.config       | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/configs/kernel-5.14.0-x86_64-debug.config 
>> b/configs/kernel-5.14.0-x86_64-debug.config
>> index 5591639ae0281..30fe2448a0216 100644
>> --- a/configs/kernel-5.14.0-x86_64-debug.config
>> +++ b/configs/kernel-5.14.0-x86_64-debug.config
>> @@ -4328,8 +4328,8 @@ CONFIG_PROVE_NVDIMM_LOCKING=y
>>   CONFIG_PROVIDE_OHCI1394_DMA_INIT=y
>>   CONFIG_PSAMPLE=m
>>   # CONFIG_PSE_CONTROLLER is not set
>> -CONFIG_PSI_DEFAULT_DISABLED=y
>>   CONFIG_PSI=y
>> +# CONFIG_PSI_DEFAULT_DISABLED is not set
>>   # CONFIG_PSTORE_842_COMPRESS is not set
>>   # CONFIG_PSTORE_BLK is not set
>>   # CONFIG_PSTORE_CONSOLE is not set
>> diff --git a/configs/kernel-5.14.0-x86_64.config 
>> b/configs/kernel-5.14.0-x86_64.config
>> index 0300167dcddf6..3c5caa765ecd6 100644
>> --- a/configs/kernel-5.14.0-x86_64.config
>> +++ b/configs/kernel-5.14.0-x86_64.config
>> @@ -4307,8 +4307,8 @@ CONFIG_PROVE_NVDIMM_LOCKING=y
>>   CONFIG_PROVIDE_OHCI1394_DMA_INIT=y
>>   CONFIG_PSAMPLE=m
>>   # CONFIG_PSE_CONTROLLER is not set
>> -CONFIG_PSI_DEFAULT_DISABLED=y
>>   CONFIG_PSI=y
>> +# CONFIG_PSI_DEFAULT_DISABLED is not set
>>   # CONFIG_PSTORE_842_COMPRESS is not set
>>   # CONFIG_PSTORE_BLK is not set
>>   # CONFIG_PSTORE_CONSOLE is not set
> _______________________________________________
> Devel mailing list
> Devel at openvz.org
> https://lists.openvz.org/mailman/listinfo/devel



More information about the Devel mailing list