[Devel] [PATCH VZ9 2/2] fs/fuse kio: introduce pcs_krpc - export kernel RPC to userspace

[Vasily Averin]

On 5/16/24 17:22, Liu Kui wrote:
> diff --git a/fs/fuse/kio/pcs/pcs_fuse_kdirect.c b/fs/fuse/kio/pcs/pcs_fuse_kdirect.c
> index 566dcb5f2f4c..0ca76556bf13 100644
> --- a/fs/fuse/kio/pcs/pcs_fuse_kdirect.c
> +++ b/fs/fuse/kio/pcs/pcs_fuse_kdirect.c
> @@ -1935,10 +2012,13 @@ static int __init kpcs_mod_init(void)
>  	if (IS_ERR(crc_tfm))
>  		crc_tfm = NULL;
>  
> +   <<<<<< Extra empty line?
>  	printk("%s fuse_c:%p ireq_c:%p pcs_wq:%p\n", __FUNCTION__,
>  	       pcs_fuse_req_cachep, pcs_ireq_cachep, pcs_wq);
>  
>  	return 0;
> +free_krpc:
> +	pcs_krpc_fini();   <<<<< (A) case, see reference below
>  free_csa:
>  	pcs_csa_fini();
>  free_cleanup_wq:
> @@ -1968,6 +2048,7 @@ static void __exit kpcs_mod_exit(void)
>  	kmem_cache_destroy(pcs_ireq_cachep);
>  	kmem_cache_destroy(pcs_fuse_req_cachep);
>  	pcs_csa_fini();
> +	pcs_krpc_fini();    <<<< order of fini calls differs from (A). Right now it does not look critical, but anyway.
>  }
>  
>  module_init(kpcs_mod_init);