[Devel] [PATCH RHEL9 COMMIT] fs/fuse/pcs: remove useless fuse call

Konstantin Khorenko khorenko at virtuozzo.com
Fri Mar 8 21:12:11 MSK 2024


The commit is pushed to "branch-rh9-5.14.0-362.8.1.vz9.35.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh9-5.14.0-362.8.1.vz9.35.14
------>
commit a39ef62694af1f3b4e1ea67d89e054c1c3d3f229
Author: Alexey Kuznetsov <kuznet at virtuozzo.com>
Date:   Wed Feb 28 01:00:43 2024 +0800

    fs/fuse/pcs: remove useless fuse call
    
    fuse makes an entirely noop yet wasting lots of time call
    to user space every fsync().
    
    Actually, it was a surprize from mainstream, which used
    to corrupt vstorage in vz9 and late vz7. We put a strut
    to prevent corruption bd7d3266.. "fuse: illegal access to file in vstorage"
    
    Now it is time to remove this strut completely
    algother with this nonsensial call.
    
    NOTE: for vstorage only, flag close_wait is ours.
    But actually I see no way how this call could be used
    for something not destructive for any fuse backend.
    Whatever, it is not our problem.
    
    https://pmc.acronis.work/browse/VSTOR-79527
    
    Signed-off-by: Alexey Kuznetsov <kuznet at virtuozzo.com>
---
 fs/fuse/file.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 978007aee323..64248b64d981 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2211,11 +2211,10 @@ int fuse_write_inode(struct inode *inode, struct writeback_control *wbc)
 	struct fuse_file *ff;
 	int err;
 
-	ff = __fuse_write_file_get(fc, fi);
-	if (!ff && fc->close_wait) {
-		WARN_ON(1);
+	if (fc->close_wait)
 		return 0;
-	}
+
+	ff = __fuse_write_file_get(fc, fi);
 	err = fuse_flush_times(inode, ff);
 	if (ff)
 		fuse_file_put(ff, false, false);


More information about the Devel mailing list