[Devel] [PATCH RHEL9 COMMIT] dm-qcow2: Drop debug warnings on uninitiallized bi_io_vec detections
Konstantin Khorenko
khorenko at virtuozzo.com
Mon Jul 22 18:21:38 MSK 2024
The commit is pushed to "branch-rh9-5.14.0-427.22.1.vz9.62.x-ovz" and will appear at git at bitbucket.org:openvz/vzkernel.git
after rh9-5.14.0-427.22.1.vz9.62.7
------>
commit f412c0597b6a80502c0874e705ec55db22709231
Author: Konstantin Khorenko <khorenko at virtuozzo.com>
Date: Mon Jul 22 18:17:06 2024 +0300
dm-qcow2: Drop debug warnings on uninitiallized bi_io_vec detections
So, now we have caught triggered warnings and have data for further
investigation, it's time to drop those debug warnings, so they won't
scare people and auto tests.
Fixes: 4f7a049f70bc ("dm-qcow2: use bio inline vecs in case bi_io_vec is
not initiallized")
https://virtuozzo.atlassian.net/browse/PSBM-157238
Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
Feature: dm-qcow2: debug
---
drivers/md/dm-qcow2-map.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/md/dm-qcow2-map.c b/drivers/md/dm-qcow2-map.c
index 7944e33af8f0..137fb9a270cd 100644
--- a/drivers/md/dm-qcow2-map.c
+++ b/drivers/md/dm-qcow2-map.c
@@ -1246,7 +1246,6 @@ static void __submit_rw_mapped(struct qcow2 *qcow2, struct qio *qio, u32 nr_segs
rw = (op_is_write(qio->bi_op) ? WRITE : READ);
bvec = __bvec_iter_bvec(qio->bi_io_vec, qio->bi_iter);
- WARN_ON_ONCE(!bvec);
pos = to_bytes(qio->bi_iter.bi_sector);
iov_iter_bvec(&iter, rw, bvec, nr_segs, qio->bi_iter.bi_size);
@@ -3554,7 +3553,6 @@ static void prepare_one_embedded_qio(struct qcow2 *qcow2, struct qio *qio,
} else {
/* Single bio already provides bvec array */
bvec = rq->bio->bi_io_vec;
- WARN_ON_ONCE(!bvec);
if (!bvec) {
bvec = rq->bio->bi_inline_vecs;
if (unlikely(!bvec)) {
@@ -3777,7 +3775,6 @@ static int prepare_sliced_data_write(struct qcow2 *qcow2, struct qio *qio,
}
write_qio->bi_io_vec = qvec->bvec;
- WARN_ON_ONCE(!write_qio->bi_io_vec);
write_qio->bi_iter.bi_idx = 0;
write_qio->bi_iter.bi_bvec_done = 0;
@@ -4234,7 +4231,6 @@ void qcow2_submit_embedded_qio(struct qcow2_target *tgt, struct qio *qio)
qcow2 = qcow2_ref_inc(tgt, &ref_index);
if (blk_rq_bytes(rq)) {
- WARN_ON_ONCE(rq->bio && !rq->bio->bi_io_vec);
queue_list_id = QLIST_EMBEDDED;
worker = &qcow2->worker;
} else {
More information about the Devel
mailing list