[Devel] [PATCH v2 VZ9 2/4] vhost-blk: remove excess vhost_blk_req.use_inline

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Mon Dec 30 08:39:49 MSK 2024


We already have all information in vhost_blk_req.bio itself, so we can
save place in vhost_blk_req.

https://virtuozzo.atlassian.net/browse/PSBM-157752
Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
---
 drivers/vhost/blk.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/vhost/blk.c b/drivers/vhost/blk.c
index a289552d6f377..0c80967bfeee1 100644
--- a/drivers/vhost/blk.c
+++ b/drivers/vhost/blk.c
@@ -54,7 +54,6 @@ enum {
 struct vhost_blk_req {
 	struct bio *inline_bio[NR_INLINE];
 	int req_bin;
-	bool use_inline;
 
 	struct llist_node llnode;
 
@@ -160,7 +159,7 @@ static void vhost_blk_req_done(struct bio *bio)
 
 static void vhost_blk_req_cleanup(struct vhost_blk_req *req)
 {
-	if (!req->use_inline)
+	if (req->bio != req->inline_bio)
 		kfree(req->bio);
 }
 
@@ -169,7 +168,6 @@ static int vhost_blk_bio_make_simple(struct vhost_blk_req *req,
 {
 	struct bio *bio;
 
-	req->use_inline = true;
 	req->bio = req->inline_bio;
 
 	bio = bio_alloc(bdev, 0, req->bi_opf, GFP_KERNEL);
@@ -207,9 +205,7 @@ static int vhost_blk_bio_make(struct vhost_blk_req *req,
 				   GFP_KERNEL);
 		if (!req->bio)
 			return -ENOMEM;
-		req->use_inline = false;
 	} else {
-		req->use_inline = true;
 		req->bio = req->inline_bio;
 	}
 
-- 
2.47.0



More information about the Devel mailing list