[Devel] [RFC PATCH vz9 v6 53/62] dm-ploop: remove unnecessary operations

Alexander Atanasov alexander.atanasov at virtuozzo.com
Fri Dec 6 00:56:26 MSK 2024


- no point to sync before write
- no point to reverse the list order since it is resubmit and
order is lost  already

https://virtuozzo.atlassian.net/browse/VSTOR-91821
Signed-off-by: Alexander Atanasov <alexander.atanasov at virtuozzo.com>
---
 drivers/md/dm-ploop-cmd.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/md/dm-ploop-cmd.c b/drivers/md/dm-ploop-cmd.c
index c919d796e108..466c09d23a22 100644
--- a/drivers/md/dm-ploop-cmd.c
+++ b/drivers/md/dm-ploop-cmd.c
@@ -137,7 +137,7 @@ static void ploop_resume_submitting_pios(struct ploop *ploop)
 
 	suspended_pending = llist_del_all(&ploop->llsuspended_pios);
 	if (suspended_pending)
-		ploop_submit_embedded_pios(ploop, llist_reverse_order(suspended_pending));
+		ploop_submit_embedded_pios(ploop, suspended_pending);
 }
 
 static int ploop_suspend_submitting_pios(struct ploop *ploop)
@@ -243,11 +243,6 @@ static int ploop_write_cluster_sync(struct ploop *ploop, struct pio *pio,
 {
 	struct file *file = ploop_top_delta(ploop)->file;
 	DECLARE_COMPLETION_ONSTACK(completion);
-	int ret;
-
-	ret = vfs_fsync(file, 0);
-	if (ret)
-		return ret;
 
 	ploop_init_pio(ploop, REQ_OP_WRITE, pio);
 	ploop_pio_prepare_offsets(ploop, pio, dst_clu);
-- 
2.43.0



More information about the Devel mailing list