[Devel] [PATCH RHEL9 COMMIT] net: neigh: add skb drop reasons to arp_error_report()

Konstantin Khorenko khorenko at virtuozzo.com
Mon Jan 16 20:56:45 MSK 2023


The commit is pushed to "branch-rh9-5.14.0-162.6.1.vz9.18.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh9-5.14.0-162.6.1.vz9.18.2
------>
commit a3a1d478c7e4c67699b24a2b96722be7301b8889
Author: Menglong Dong <imagedong at tencent.com>
Date:   Tue Jan 3 17:39:16 2023 +0200

    net: neigh: add skb drop reasons to arp_error_report()
    
    When neighbour become invalid or destroyed, neigh_invalidate() will be
    called. neigh->ops->error_report() will be called if the neighbour's
    state is NUD_FAILED, and seems here is the only use of error_report().
    So we can tell that the reason of skb drops in arp_error_report() is
    SKB_DROP_REASON_NEIGH_FAILED.
    
    Replace kfree_skb() used in arp_error_report() with kfree_skb_reason().
    
    Reviewed-by: Mengen Sun <mengensun at tencent.com>
    Reviewed-by: Hao Peng <flyingpeng at tencent.com>
    Signed-off-by: Menglong Dong <imagedong at tencent.com>
    Reviewed-by: David Ahern <dsahern at kernel.org>
    Signed-off-by: David S. Miller <davem at davemloft.net>
    Acked-by: Nikolay Borisov <nborisov at suse.com>
    Signed-off-by: Nikolay Borisov <nikolay.borisov at virtuozzo.com>
    
    ======
    Patchset description:
    ms/net: Annotate skb free sites with reason
    
    This series backports most of the patches that add a reason to skb free sites.
    
    https://jira.sw.ru/browse/PSBM-143302
    
    Feature: net: improve verbosity of dropped packets reporting
---
 net/ipv4/arp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
index 8d0f5f761e5f..40d40696ac7c 100644
--- a/net/ipv4/arp.c
+++ b/net/ipv4/arp.c
@@ -293,7 +293,7 @@ static int arp_constructor(struct neighbour *neigh)
 static void arp_error_report(struct neighbour *neigh, struct sk_buff *skb)
 {
 	dst_link_failure(skb);
-	kfree_skb(skb);
+	kfree_skb_reason(skb, SKB_DROP_REASON_NEIGH_FAILED);
 }
 
 /* Create and send an arp packet. */


More information about the Devel mailing list