[Devel] [PATCH RH9 v4 01/10] drivers/vhost: vhost-blk accelerator for virtio-blk guests

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Fri Nov 4 11:34:31 MSK 2022


This codding style is wrong:

On 01.11.2022 10:25, Andrey Zhadchenko wrote:
> +static void vhost_blk_req_done(struct bio *bio)
> +{
> +	struct vhost_blk_req *req = bio->bi_private;
> +	struct vhost_blk *blk = req->blk;
> +	int err = blk_status_to_errno(bio->bi_status);
> +
> +	if (err)
> +		req->bio_err = err;

should be:

funca()
{
         int err;

         err = funcb();
         if (err)
                 do_something;
}

Please fix.

-- 
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.


More information about the Devel mailing list