[Devel] [PATCH RH7] netfilter: nf_tables: fix chain filter in nf_tables_dump_rules()

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Mon Aug 15 20:12:19 MSK 2022


From: Pablo Neira Ayuso <pablo at netfilter.org>

ctx->chain may be null now that we have very large object names,
so we cannot check for ctx->chain[0] here.

Fixes: b7263e071aba7 ("netfilter: nf_tables: Allow table names of up to 255 chars")
Signed-off-by: Pablo Neira Ayuso <pablo at netfilter.org>
Acked-by: Phil Sutter <phil at nwl.cc>

https://jira.sw.ru/browse/PSBM-141578
(cherry picked from ms commit 24c0df82ef7919e4d10cf2e4e65d368eb2e8ea21)
Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
---
 net/netfilter/nf_tables_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index afada68cac7e..22d00c3b5440 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -1946,7 +1946,7 @@ static int nf_tables_dump_rules(struct sk_buff *skb,
 				continue;
 
 			list_for_each_entry_rcu(chain, &table->chains, list) {
-				if (ctx && ctx->chain[0] &&
+				if (ctx && ctx->chain &&
 				    strcmp(ctx->chain, chain->name) != 0)
 					continue;
 
-- 
2.37.1



More information about the Devel mailing list