[Devel] [PATCH RH9 08/30] sctp: suppress warnings on high order memory allocation on sctp chunk creation

Andrey Zhadchenko andrey.zhadchenko at virtuozzo.com
Tue Sep 28 21:48:59 MSK 2021


From: Konstantin Khorenko <khorenko at virtuozzo.com>

_sctp_make_chunk() could allocate skbs up to 65K in size
(4th order page), so we get complains about high order page
allocations from our detection mechanizm while running sctp
testsuite.

It's not evident that substituting alloc_skb() with
alloc_skb_with_frags() speeds up the sender performance.
On another hand if the node's memory is highly fragmented
and allocation of high order pages has noticable latency,
it influences the sender most, not the node as a whole.

And taking into account that sctp is not widely used,
let's just shut up the warning in this place.

https://jira.sw.ru/browse/PSBM-93798

Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>

(cherry-picked from vz7 commit ba10a40a017e ("sctp: suppress warnings on high
order memory allocation on sctp chunk creation"))

https://jira.sw.ru/browse/PSBM-127848
Signed-off-by: Valeriy Vdovin <valeriy.vdovin at virtuozzo.com>

(cherry picked from vz8 commit 19ced9d4018b2e15b5894bf6636205fd2c1008a5)
Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko at virtuozzo.com>
---
 net/sctp/sm_make_chunk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index b8fa8f1..78929f8 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -1440,7 +1440,7 @@ static struct sctp_chunk *_sctp_make_chunk(const struct sctp_association *asoc,
 		goto nodata;
 
 	/* No need to allocate LL here, as this is only a chunk. */
-	skb = alloc_skb(chunklen, gfp);
+	skb = alloc_skb(chunklen, gfp | __GFP_ORDER_NOWARN);
 	if (!skb)
 		goto nodata;
 
-- 
1.8.3.1



More information about the Devel mailing list