[Devel] [PATCH RH7] Revert "sysctl: make "tcp_syncookies" sysctl available inside a CT"

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Fri Sep 24 16:03:11 MSK 2021



On 24.09.2021 14:33, Pavel Tikhomirov wrote:
> This reverts commit b108b8e6f129d97d720d8c4143805c6587b156a6.
> 
> Found that this patch is useless while porting to vz9. On vz7 this
> sysctl file exists only in init netns, on vz8 it is visible in CT anyway
> as it is virtualized in mainstream.
> 
> https://jira.sw.ru/browse/PSBM-133988
> Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
> ---
>   net/ipv4/sysctl_net_ipv4.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
> index f53f7d476208..9888d556af39 100644
> --- a/net/ipv4/sysctl_net_ipv4.c
> +++ b/net/ipv4/sysctl_net_ipv4.c
> @@ -421,7 +421,7 @@ static struct ctl_table ipv4_table[] = {
>   		.procname	= "tcp_syncookies",
>   		.data		= &sysctl_tcp_syncookies,
>   		.maxlen		= sizeof(int),
> -		.mode		= 0644 | S_ISVTX,
> +		.mode		= 0644,
>   		.proc_handler	= proc_dointvec_immutable,

Hm that's probably good to also remove immutable handler here. Will resend.

>   	},
>   #endif
> 

-- 
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.


More information about the Devel mailing list