[Devel] [PATCH RH7] RCU pathwalk breakage when running into a symlink overmounting something

[Pavel Tikhomirov]

From: Al Viro <viro at zeniv.linux.org.uk>

Calling unlazy_walk() in walk_component() and do_last() when we find
a symlink that needs to be followed doesn't acquire a reference to vfsmount.
That's fine when the symlink is on the same vfsmount as the parent directory
(which is almost always the case), but it's not always true - one _can_
manage to bind a symlink on top of something.  And in such cases we end up
with excessive mntput().

Cc: stable at vger.kernel.org # since 2.6.39
Signed-off-by: Al Viro <viro at zeniv.linux.org.uk>

--

When symlink-symlink bindmount is created on ploop, which is posible
after we've ported open_tree()+move_mount() kernel interface, calling
lstat on it makes excess decrement of the bindmount's mnt_pcp refcount,
which leads to leaked mount and thus blocks ploop device and thus
blocks container. So after this symlink-symlink bindmount is added in
container one can't restart this container.

https://jira.sw.ru/browse/PSBM-129639
(cherry-pick from ms 3cab989afd8d8d1bc3d99fef0e7ed87c31e7b647)
Signed-off-by: Pavel Tikhomirov <ptikhomirov at virtuozzo.com>
---
 fs/namei.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/namei.c b/fs/namei.c
index a25c05a5f124..85c0ffa0c55c 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -1601,7 +1601,8 @@ static inline int walk_component(struct nameidata *nd, struct path *path,
 
 	if (should_follow_link(path->dentry, follow)) {
 		if (nd->flags & LOOKUP_RCU) {
-			if (unlikely(unlazy_walk(nd, path->dentry))) {
+			if (unlikely(nd->path.mnt != path->mnt ||
+				     unlazy_walk(nd, path->dentry))) {
 				err = -ECHILD;
 				goto out_err;
 			}
@@ -3208,7 +3209,8 @@ static int do_last(struct nameidata *nd, struct path *path,
 
 	if (should_follow_link(path->dentry, !symlink_ok)) {
 		if (nd->flags & LOOKUP_RCU) {
-			if (unlikely(unlazy_walk(nd, path->dentry))) {
+			if (unlikely(nd->path.mnt != path->mnt ||
+				     unlazy_walk(nd, path->dentry))) {
 				error = -ECHILD;
 				goto out;
 			}
-- 
2.31.1