[Devel] [PATCH RHEL8 COMMIT] Revert "target: add read/write/sync latency counter"

Konstantin Khorenko khorenko at virtuozzo.com
Wed Jun 9 20:18:08 MSK 2021


The commit is pushed to "branch-rh8-4.18.0-240.1.1.vz8.5.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh8-4.18.0-240.1.1.vz8.5.38
------>
commit 453c74703c3bab4a7e156dc513ea77e15c3d9f85
Author: Konstantin Khorenko <khorenko at virtuozzo.com>
Date:   Wed Jun 9 20:16:04 2021 +0300

    Revert "target: add read/write/sync latency counter"
    
    This reverts commit c06435eb5e1154345c78d3fd0f703bedd2c7bb40.
    
    It turned out that we/pStorage don't use tgtd anymore =>
    dropping patches.
    
    Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
---
 drivers/target/target_core_stat.c | 4 ----
 include/target/target_core_base.h | 1 -
 2 files changed, 5 deletions(-)

diff --git a/drivers/target/target_core_stat.c b/drivers/target/target_core_stat.c
index abe7f612b676..07ce36e83f91 100644
--- a/drivers/target/target_core_stat.c
+++ b/drivers/target/target_core_stat.c
@@ -632,7 +632,6 @@ void scsi_port_stats_hist_observe(
 		return;
 
 	scsi_port_stats_hist_observe_bsearch(hist, val);
-	atomic64_add(val, &hist->latencies);
 }
 
 static ssize_t find_token(const char *page, size_t size,
@@ -726,9 +725,6 @@ static ssize_t snprintf_histogram(char *page, size_t size,
 	ret += snprintf(page + ret, PAGE_SIZE - ret,
 		"%llu\n", (u64)atomic64_read(&hist->counters[i]));
 
-	ret += snprintf(page + ret, PAGE_SIZE - ret,
-		"%llu\n", (u64)atomic64_read(&hist->latencies));
-
 	return ret;
 }
 
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h
index 2622fd654bec..82a87ce349ab 100644
--- a/include/target/target_core_base.h
+++ b/include/target/target_core_base.h
@@ -719,7 +719,6 @@ struct scsi_port_stats_hist {
 	u64		items[TCM_SE_PORT_STATS_HIST_MAX];
 	atomic64_t	counters[TCM_SE_PORT_STATS_HIST_MAX];
 	u8		count;
-	atomic64_t	latencies;
 	struct rcu_head	rcu_head;
 };
 


More information about the Devel mailing list