[Devel] [PATCH RH7] ms/memcg: drop GFP_KERNEL_ACCOUNT use in tty_free_termios()

Vasily Averin vvs at virtuozzo.com
Tue Jul 27 12:35:04 MSK 2021


Jiri Slaby pointed that termios are not saved for PTYs and for other
terminals used inside containers. Therefore accounting for saved
termios have near to zero impact in real life scenarios.

Taken from upstream commit ("memcg: drop GFP_KERNEL_ACCOUNT use in tty_save_termios()")
Signed-off-by: Vasily Averin <vvs at virtuozzo.com>
---
 drivers/tty/tty_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 9c7fb959815b..5bec5c9191fe 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1555,7 +1555,7 @@ void tty_free_termios(struct tty_struct *tty)
 	/* Stash the termios data */
 	tp = tty->driver->termios[idx];
 	if (tp == NULL) {
-		tp = kmalloc(sizeof(struct ktermios), GFP_KERNEL_ACCOUNT);
+		tp = kmalloc(sizeof(struct ktermios), GFP_KERNEL);
 		if (tp == NULL) {
 			pr_warn("tty: no memory to save termios state.\n");
 			return;
-- 
2.25.1



More information about the Devel mailing list