[Devel] [PATCH RHEL8 COMMIT] ploop: Pass type argument to ploop_prepare_bat_update()

Konstantin Khorenko khorenko at virtuozzo.com
Fri Jul 2 22:43:25 MSK 2021


The commit is pushed to "branch-rh8-4.18.0-240.1.1.vz8.6.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh8-4.18.0-240.1.1.el8
------>
commit e69d3ccce66fd5c5bc8d83f1930cf37c094175d2
Author: Kirill Tkhai <ktkhai at virtuozzo.com>
Date:   Fri Jul 2 22:43:25 2021 +0300

    ploop: Pass type argument to ploop_prepare_bat_update()
    
    Signed-off-by: Kirill Tkhai <ktkhai at virtuozzo.com>
    
    ==========================
    Parallel async BAT pages submission and improvements
    
    [1-15]:
    https://jira.sw.ru/browse/PSBM-124550
    
    [16-22]:
    following improvements
    
    Kirill Tkhai (22):
          ploop: Remove absolet comment
          ploop: Add md and piwb cross pointers
          ploop: Add @md argument to locate_new_cluster_and_attach_pio()
          ploop: Refactoring in process_one_discard_pio()
          ploop: Pass type argument to ploop_prepare_bat_update()
          ploop: Move md is busy check to delay_if_md_busy()
          ploop: Introduce batch list for md pages writeback
          ploop: Check for md dirty instead of md piwb
          ploop: Reread piwb after ploop_prepare_bat_update()
          ploop: Change argument in ploop_prepare_bat_update()
          ploop: Return md from ploop_prepare_reloc_index_wb()
          ploop: Change arguments and rename ploop_reset_bat_update()
          ploop: Allow parallel wb of md pages
          ploop: Async md writeback
          ploop: Rename ploop_submit_index_wb_sync()
          ploop: Resubmit pios from main kwork
          ploop: Rename process_delta_wb()
          ploop: Do fsync after bat page write
          ploop: Do not iterate excess clusters in notify_delta_merged()
          ploop: Use kvec in ploop_delta_check_header()
          ploop: Add argument to ploop_read_delta_metadata()
          ploop: Underline clu and page is u32
---
 drivers/md/dm-ploop-map.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/drivers/md/dm-ploop-map.c b/drivers/md/dm-ploop-map.c
index 1b1313a8b057..ce65da6988bf 100644
--- a/drivers/md/dm-ploop-map.c
+++ b/drivers/md/dm-ploop-map.c
@@ -763,7 +763,7 @@ static void ploop_bat_write_complete(struct ploop_index_wb *piwb,
 }
 
 static int ploop_prepare_bat_update(struct ploop *ploop, unsigned int page_id,
-				    struct ploop_index_wb *piwb)
+			     struct ploop_index_wb *piwb, enum piwb_type type)
 {
 	unsigned int i, off, last, *bat_entries;
 	bool is_last_page = true;
@@ -816,6 +816,8 @@ static int ploop_prepare_bat_update(struct ploop *ploop, unsigned int page_id,
 
 	kunmap_atomic(to);
 	kunmap_atomic(bat_entries);
+
+	piwb->type = type;
 	return 0;
 }
 
@@ -1244,7 +1246,7 @@ static void submit_cow_index_wb(struct ploop_cow *cow,
 
 	if (piwb->page_id == PAGE_NR_NONE) {
 		/* No index wb in process. Prepare a new one */
-		if (ploop_prepare_bat_update(ploop, page_id, piwb) < 0)
+		if (ploop_prepare_bat_update(ploop, page_id, piwb, PIWB_TYPE_ALLOC) < 0)
 			goto err_resource;
 	}
 
@@ -1335,7 +1337,7 @@ static bool locate_new_cluster_and_attach_pio(struct ploop *ploop,
 
 	if (piwb->page_id == PAGE_NR_NONE) {
 		/* No index wb in process. Prepare a new one */
-		if (ploop_prepare_bat_update(ploop, page_id, piwb) < 0) {
+		if (ploop_prepare_bat_update(ploop, page_id, piwb, PIWB_TYPE_ALLOC) < 0) {
 			pio->bi_status = BLK_STS_RESOURCE;
 			goto error;
 		}
@@ -1475,11 +1477,10 @@ static void process_one_discard_pio(struct ploop *ploop, struct pio *pio,
 
 	if (piwb->page_id == PAGE_NR_NONE) {
 		/* No index wb in process. Prepare a new one */
-		if (ploop_prepare_bat_update(ploop, page_id, piwb) < 0) {
+		if (ploop_prepare_bat_update(ploop, page_id, piwb, PIWB_TYPE_DISCARD) < 0) {
 			pio->bi_status = BLK_STS_RESOURCE;
 			goto err;
 		}
-		piwb->type = PIWB_TYPE_DISCARD;
 		bat_update_prepared = true;
 	}
 
@@ -1764,9 +1765,13 @@ int ploop_prepare_reloc_index_wb(struct ploop *ploop,
 				 unsigned int *dst_clu)
 {
 	unsigned int page_id = bat_clu_to_page_nr(clu);
+	enum piwb_type type = PIWB_TYPE_ALLOC;
+
+	if (dst_clu)
+		type = PIWB_TYPE_RELOC;
 
 	if (piwb->page_id != PAGE_NR_NONE ||
-	    ploop_prepare_bat_update(ploop, page_id, piwb))
+	    ploop_prepare_bat_update(ploop, page_id, piwb, type))
 		goto out_eio;
 	if (dst_clu) {
 		/*
@@ -1775,7 +1780,6 @@ int ploop_prepare_reloc_index_wb(struct ploop *ploop,
 		 * to make ploop_alloc_cluster() allocate new dst_clu from
 		 * holes_bitmap.
 		 */
-		piwb->type = PIWB_TYPE_RELOC;
 		ploop_bat_page_zero_cluster(ploop, piwb, clu);
 		if (ploop_alloc_cluster(ploop, piwb, clu, dst_clu))
 			goto out_reset;


More information about the Devel mailing list