[Devel] [PATCH] scripts/checkpatch.pl: fixed regression after COPYING was renamed

[Konstantin Khorenko]

--
Best regards,

Konstantin Khorenko,
Virtuozzo Linux Kernel Team

On 01/20/2021 10:15 AM, Vasily Averin wrote:
> according to
> https://access.redhat.com/labs/rhcb/RHEL-8.3/kernel-4.18.0-240.10.1.el8/sources/
> original RHEL8 kernel uses COPYING name.
>  problem was happen during our rebase.
> Kostja,
> could you please take look at your build scripts?

"rpmbuild -bp" renames "COPYING" file.

RHEL8 kernel.spec:
...
chmod +x scripts/checkpatch.pl
mv COPYING COPYING-%{version}
...

i suspect the following patch is related, but did not find the content of the patch yet:
- [rpmspec] fix conflicts with COPYING file while installing newer 4.17 kernel ("Herton R. Krzesinski") [1579563]

>
> Thank you,
> 	Vasily Averin
> 	
> On 1/20/21 1:51 AM, Valeriy Vdovin wrote:
>> fixes: 90e3b8f80b22002418d3056438a82837769c4691
>> checpatch.pl first checks that the script is run from top of kernel tree.
>> it does so by calling top_of_kernel_tree function, which has a hardcoded
>> set of files that are enough to identify top of tree by their presence.
>> The troublesome patch renames COPYING by adding prefix and so the check
>> fails.
>>
>> Signed-off-by: Valeriy Vdovin <valeriy.vdovin at virtuozzo.com>
>> ---
>>  scripts/checkpatch.pl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index 4d80526..cb9cddd 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -1069,7 +1069,7 @@ sub top_of_kernel_tree {
>>  	my ($root) = @_;
>>
>>  	my @tree_check = (
>> -		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
>> +		"COPYING-4.18.0", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
>>  		"README", "Documentation", "arch", "include", "drivers",
>>  		"fs", "init", "ipc", "kernel", "lib", "scripts",
>>  	);
>>
> .
>