[Devel] [PATCH vz7 4/4] ms/fuse: async processing of F_SETLK with FL_SLEEP flag

Vasily Averin vvs at virtuozzo.com
Thu Dec 30 14:50:05 MSK 2021


kernel export thread (nfsd/lockd/ksmbd) use F_SETLK cmd with set FL_SLEEP
flag to request asynchronous processing of blocking locks.
Fuse does not support async processing and should drop FL_SLEEP flag
to avoid execution of blocking FUSE_SETLKW request.
Dropped FL_SLEEP flag should be restored back, because it can be used
in caller, at least in nfsd4_lock() does it actually.

https://bugzilla.kernel.org/show_bug.cgi?id=215383
(patch was submitted upstream but not merged yet)
https://jira.sw.ru/browse/PSBM-136851
Signed-off-by: Vasily Averin <vvs at virtuozzo.com>
---
 fs/fuse/file.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index dd98166f6a6b..7114482456ba 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2808,8 +2808,17 @@ static int fuse_file_lock(struct file *file, int cmd, struct file_lock *fl)
 	} else {
 		if (fc->no_lock)
 			err = posix_lock_file(file, fl, NULL);
-		else
+		else {
+			bool async = (fl->fl_flags & FL_SLEEP) && IS_SETLK(cmd);
+
+			if (async)
+				fl->fl_flags &= ~FL_SLEEP;
+
 			err = fuse_setlk(file, fl, 0);
+
+			if (async)
+				fl->fl_flags |= FL_SLEEP;
+		}
 	}
 	return err;
 }
-- 
2.25.1



More information about the Devel mailing list