[Devel] [PATCH RHEL9 COMMIT] ms/nfsd: don't put blocked locks on LRU until after vfs_lock_file returns

[Konstantin Khorenko]

The commit is pushed to "branch-rh9-5.14.vz9.1.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh9-5.14.0-4.vz9.10.33
------>
commit 11403ddc5f3ba8b9c7c97a5ced50289319ac3096
Author: Jeff Layton <jlayton at kernel.org>
Date:   Tue Dec 7 16:54:16 2021 +0300

    ms/nfsd: don't put blocked locks on LRU until after vfs_lock_file returns
    
    Vasily reported a case where vfs_lock_file took a very long time to
    return (longer than a lease period). The laundromat eventually ran and
    reaped the thing and when the vfs_lock_file returned, it ended up
    accessing freed memory.
    
    Don't put entries onto the LRU until vfs_lock_file returns.
    
    Cc: stable at vger.kernel.org
    mFixes: 7919d0a27f1e "nfsd: add a LRU list for blocked locks"
    Reported-by: Vasily Averin <vvs at virtuozzo.com>
    Signed-off-by: Jeff Layton <jlayton at kernel.org>
    Tested-by: Vasily Averin <vvs at virtuozzo.com>
    
    https://lore.kernel.org/all/20211123122223.69236-1-jlayton@kernel.org/
    https://jira.sw.ru/browse/PSBM-133274
    Feature: fix ms/nfs
    
    Signed-off-by: Vasily Averin <vvs at virtuozzo.com>
---
 fs/nfsd/nfs4state.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index fa67ecd5fe63..ad8633811ea7 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -6963,10 +6963,8 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 	}
 
 	if (fl_flags & FL_SLEEP) {
-		nbl->nbl_time = ktime_get_boottime_seconds();
 		spin_lock(&nn->blocked_locks_lock);
 		list_add_tail(&nbl->nbl_list, &lock_sop->lo_blocked);
-		list_add_tail(&nbl->nbl_lru, &nn->blocked_locks_lru);
 		spin_unlock(&nn->blocked_locks_lock);
 	}
 
@@ -6979,6 +6977,10 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
 			nn->somebody_reclaimed = true;
 		break;
 	case FILE_LOCK_DEFERRED:
+		nbl->nbl_time = ktime_get_boottime_seconds();
+		spin_lock(&nn->blocked_locks_lock);
+		list_add_tail(&nbl->nbl_lru, &nn->blocked_locks_lru);
+		spin_unlock(&nn->blocked_locks_lock);
 		nbl = NULL;
 		fallthrough;
 	case -EAGAIN:		/* conflock holds conflicting lock */