[Devel] [PATCH vz8] kernel/sched/fair.c: Add more missing update_rq_clock() calls

Andrey Ryabinin aryabinin at virtuozzo.com
Tue Sep 29 16:55:36 MSK 2020


Add update_rq_clock() for 'target_rq' to avoid WARN() coming
from attach_task(). Also add update_rq_clock(env.src_rq); in
load_balance() for detach_task().

https://jira.sw.ru/browse/PSBM-108013
Reported-by: Kirill Tkhai <ktkhai at virtuozzo.com>
Signed-off-by: Andrey Ryabinin <aryabinin at virtuozzo.com>
---
 kernel/sched/fair.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index e6dc21d5fa03..99dcb9e77efd 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7817,6 +7817,7 @@ static int cpulimit_balance_cpu_stop(void *data)
 		schedstat_inc(sd->clb_count);
 
 		update_rq_clock(rq);
+		update_rq_clock(target_rq);
 		if (do_cpulimit_balance(&env))
 			schedstat_inc(sd->clb_pushed);
 		else
@@ -9177,6 +9178,7 @@ static int load_balance(int this_cpu, struct rq *this_rq,
 			env.loop = 0;
 			local_irq_save(rf.flags);
 			double_rq_lock(env.dst_rq, busiest);
+			update_rq_clock(env.src_rq);
 			update_rq_clock(env.dst_rq);
 			cur_ld_moved = ld_moved = move_task_groups(&env);
 			double_rq_unlock(env.dst_rq, busiest);
-- 
2.26.2



More information about the Devel mailing list