[Devel] [PATCH RH7] Revert "xfs: catch bad stripe alignment configurations"

Konstantin Khorenko khorenko at virtuozzo.com
Wed Jun 3 13:09:10 MSK 2020


This reverts commit fa4ca9c5574605d1e48b7e617705230a0640b6da.

RHEL 7.8: XFS filesystem can not be mounted after a kernel upgrade

* Following an update to kernel-3.10.0-1127.el7, a XFS file system can
  not be mounted.
* If the system is booted into a previous version of RHEL, the XFS file
  system can be mounted.
* Newly created XFS file systems on RHEL 7.8 can not be mounted.

This is a part of new RHEL7.8 kernel-3.10.0-1127.10.1.el7.

https://access.redhat.com/errata/RHBA-2020:2355
https://access.redhat.com/solutions/5075561

Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
---
 fs/xfs/libxfs/xfs_sb.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
index 3d01f81d06d0e..5b830bb351156 100644
--- a/fs/xfs/libxfs/xfs_sb.c
+++ b/fs/xfs/libxfs/xfs_sb.c
@@ -273,22 +273,6 @@ xfs_mount_validate_sb(
 		return -EFSCORRUPTED;
 	}
 
-	if (sbp->sb_unit) {
-		if (!xfs_sb_version_hasdalign(sbp) ||
-		    sbp->sb_unit > sbp->sb_width ||
-		    (sbp->sb_width % sbp->sb_unit) != 0) {
-			xfs_notice(mp, "SB stripe unit sanity check failed");
-			return -EFSCORRUPTED;
-		}
-	} else if (xfs_sb_version_hasdalign(sbp)) {
-		xfs_notice(mp, "SB stripe alignment sanity check failed");
-		return -EFSCORRUPTED;
-	} else if (sbp->sb_width) {
-		xfs_notice(mp, "SB stripe width sanity check failed");
-		return -EFSCORRUPTED;
-	}
-
-
 	if (xfs_sb_version_hascrc(&mp->m_sb) &&
 	    sbp->sb_blocksize < XFS_MIN_CRC_BLOCKSIZE) {
 		xfs_notice(mp, "v5 SB sanity check failed");
-- 
2.15.1



More information about the Devel mailing list