[Devel] [PATCH RHEL7] perf/x86/intel: fix Intel processors define's naming

Jan Dakinevich jan.dakinevich at virtuozzo.com
Wed May 15 13:03:33 MSK 2019


On Wed, 15 May 2019 09:09:37 +0300
Konstantin Khorenko <khorenko at virtuozzo.com> wrote:

> Some Intel cpu defines were renamed, so update
> __intel_pmu_lbr_fill() where we use those defines.
> 
> Fixes: 746e059d3153 ("ms/perf/x86/intel: make reusable LBR initialization
> code")
> 
> https://jira.sw.ru/browse/PSBM-94406
> 
> Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>
> ---
>  arch/x86/events/intel/lbr.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c
> index 03dbec00eebf..bbb541552211 100644
> --- a/arch/x86/events/intel/lbr.c
> +++ b/arch/x86/events/intel/lbr.c
> @@ -1143,32 +1143,32 @@ static void __intel_pmu_lbr_fill(struct x86_pmu_lbr *lbr, u8 family, u8 model)
>  	case INTEL_FAM6_WESTMERE_EX:
>  		intel_pmu_lbr_init_nhm(lbr);
>  		break;
> -	case INTEL_FAM6_ATOM_PINEVIEW:
> -	case INTEL_FAM6_ATOM_LINCROFT:
> -	case INTEL_FAM6_ATOM_PENWELL:
> -	case INTEL_FAM6_ATOM_CLOVERVIEW:
> -	case INTEL_FAM6_ATOM_CEDARVIEW:
> +	case INTEL_FAM6_ATOM_BONNELL:
> +	case INTEL_FAM6_ATOM_BONNELL_MID:
> +	case INTEL_FAM6_ATOM_SALTWELL_MID:
> +	case INTEL_FAM6_ATOM_SALTWELL_TABLET:
> +	case INTEL_FAM6_ATOM_SALTWELL:
>  		/*
>  		 * only models starting at stepping 10 seems
>  		 * to have an operational LBR which can freeze
>  		 * on PMU interrupt
>  		 */
>  		if (apply_tweaks &&
> -		    boot_cpu_data.x86_model == INTEL_FAM6_ATOM_PINEVIEW &&
> +		    boot_cpu_data.x86_model == INTEL_FAM6_ATOM_BONNELL &&
>  		    boot_cpu_data.x86_mask < 10) {
>  			pr_cont("LBR disabled due to erratum");
>  			return;
>  		}
>  		intel_pmu_lbr_init_atom(lbr);
>  		break;
> -	case INTEL_FAM6_ATOM_SILVERMONT1:
> -	case INTEL_FAM6_ATOM_SILVERMONT2:
> +	case INTEL_FAM6_ATOM_SILVERMONT:
> +	case INTEL_FAM6_ATOM_SILVERMONT_X:
>  	case INTEL_FAM6_ATOM_AIRMONT:
>  		intel_pmu_lbr_init_slm(lbr);
>  		break;
>  	case INTEL_FAM6_ATOM_GOLDMONT:
> -	case INTEL_FAM6_ATOM_DENVERTON:
> -	case INTEL_FAM6_ATOM_GEMINI_LAKE:
> +	case INTEL_FAM6_ATOM_GOLDMONT_X:
> +	case INTEL_FAM6_ATOM_GOLDMONT_PLUS:
>  		lbr->pt_coexist = true;
>  	case INTEL_FAM6_SKYLAKE_MOBILE:
>  	case INTEL_FAM6_SKYLAKE_DESKTOP:
> @@ -1196,7 +1196,7 @@ static void __intel_pmu_lbr_fill(struct x86_pmu_lbr *lbr, u8 family, u8 model)
>  		 * OpenVZ kernel doesn't have Goldmont Plus CPU PMU support
>  		 */
>  		if (apply_tweaks &&
> -		    boot_cpu_data.x86_model == INTEL_FAM6_ATOM_GEMINI_LAKE)
> +		    boot_cpu_data.x86_model == INTEL_FAM6_ATOM_GOLDMONT_PLUS)
>  			return;
>  		intel_pmu_lbr_init_hsw(lbr);
>  		break;
> -- 
> 2.15.1
> 

Reviewed-by: Jan Dakinevich <jan.dakinevich at virtuozzo.com>


More information about the Devel mailing list