[Devel] [PATCH rh7 0/5] ploop: Remove duplicated and unused functions

Kirill Tkhai ktkhai at virtuozzo.com
Wed Jul 3 19:52:42 MSK 2019


Functions dio_sync_io() and dio_io_page() are almost identical.
Someone cloned one function into another and changed several
lines on the stage of the development. This looks bad since
it's impossible to support twice more code and backport twice
more code into new kernel versions. The patchset solves
the problem.

Also, kill unused sync vec functions.

---

Kirill Tkhai (5):
      ploop: Use BIO_EMPTY_LIST for cleanup
      ploop: Kill unused sync vec functions
      ploop: Extrack extent-related logic from dio_sync_io()
      ploop: Extract extent-related logic from dio_io_page()
      ploop: Kill __dio_io_page()


 drivers/block/ploop/io_direct.c |  274 +++++++--------------------------------
 drivers/block/ploop/io_kaio.c   |   16 --
 include/linux/ploop/ploop.h     |    6 -
 3 files changed, 50 insertions(+), 246 deletions(-)

--
Signed-off-by: Kirill Tkhai <ktkhai at virtuozzo.com>


More information about the Devel mailing list