[Devel] [PATCH vz7] ext4: replace ext4_kvmalloc() with kvmalloc()

[Oleg Babin]

On 05/11/2018 07:22 PM, Vasily Averin wrote:
> On 2018-05-11 18:13, Oleg Babin wrote:
>> On 05/11/2018 05:28 PM, Vasily Averin wrote:
>>> On 2018-05-11 17:08, Oleg Babin wrote:
>>>> @@ -1973,6 +2001,10 @@ retry:
>>>>  	if (ext4_blocks_count(es) == n_blocks_count)
>>>>  		goto out;
>>>>  
>>>> +	err = ext4_alloc_group_desc_bh_array(sb, n_group + 1);
>>>> +	if (err)
>>>> +		goto out;
>>>> +
>>>>  	err = ext4_alloc_flex_bg_array(sb, n_group + 1);
>>>>  	if (err)
>>>>  		return err;  <<<<<<< VvS
>>>
>>> Oleg,
>>> may be it is not related to your current patch set,
>>> however this "return err" looks incorrect for me,
>>> Should we probably chnge it to "goto out" too ?
>>>
>>> Could you please check it?
>>>
>>
>> Yes, I noticed this too, but decided not to touch this code in this patch.
>> This is a bug, in this case the resize inode is not freed.
>> Ok, I'll change it, thanks!
> 
> As far as I see mainline is affected too.
> Are you going to sent patch to mainline?
> Should I do it probably?

Yes, I am planning to send this patch to mainline.

-- 
Best regards,
Oleg Babin