[Devel] [PATCH vz7] ext4: replace ext4_kvmalloc() with kvmalloc()

Vasily Averin vvs at virtuozzo.com
Fri May 11 17:28:43 MSK 2018


On 2018-05-11 17:08, Oleg Babin wrote:
> @@ -1973,6 +2001,10 @@ retry:
>  	if (ext4_blocks_count(es) == n_blocks_count)
>  		goto out;
>  
> +	err = ext4_alloc_group_desc_bh_array(sb, n_group + 1);
> +	if (err)
> +		goto out;
> +
>  	err = ext4_alloc_flex_bg_array(sb, n_group + 1);
>  	if (err)
>  		return err;  <<<<<<< VvS

Oleg,
may be it is not related to your current patch set,
however this "return err" looks incorrect for me,
Should we probably chnge it to "goto out" too ?

Could you please check it?

Thank you,
	Vasily Averin



More information about the Devel mailing list