[Devel] [PATCH 07/23] target: Use correct SCSI status during EXTENDED_COPY exception
Andrei Vagin
avagin at openvz.org
Tue Mar 27 20:37:01 MSK 2018
From: Nicholas Bellinger <nab at linux-iscsi.org>
ML: 0583c261e6325f392c1f7a1b9112e31298e1a4bd
This patch adds the missing target_complete_cmd() SCSI status
parameter change in target_xcopy_do_work(), that was originally
missing in commit 926317de33.
It correctly propigates up the correct SCSI status during
EXTENDED_COPY exception cases, instead of always using the
hardcoded SAM_STAT_CHECK_CONDITION from original code.
This is required for ESX host environments that expect to
hit SAM_STAT_RESERVATION_CONFLICT for certain scenarios,
and SAM_STAT_CHECK_CONDITION results in non-retriable
status for these cases.
Reported-by: Nixon Vincent <nixon.vincent at calsoftinc.com>
Tested-by: Nixon Vincent <nixon.vincent at calsoftinc.com>
Cc: Nixon Vincent <nixon.vincent at calsoftinc.com>
Reviewed-by: Christoph Hellwig <hch at lst.de>
Cc: stable at vger.kernel.org # 3.14+
Signed-off-by: Nicholas Bellinger <nab at linux-iscsi.org>
Signed-off-by: Andrei Vagin <avagin at openvz.org>
---
drivers/target/target_core_xcopy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c
index 9f5a002..94e9574 100644
--- a/drivers/target/target_core_xcopy.c
+++ b/drivers/target/target_core_xcopy.c
@@ -881,7 +881,7 @@ out:
" CHECK_CONDITION -> sending response\n", rc);
ec_cmd->scsi_status = SAM_STAT_CHECK_CONDITION;
}
- target_complete_cmd(ec_cmd, SAM_STAT_CHECK_CONDITION);
+ target_complete_cmd(ec_cmd, ec_cmd->scsi_status);
}
sense_reason_t target_do_xcopy(struct se_cmd *se_cmd)
--
1.8.3.1
More information about the Devel
mailing list