[Devel] [PATCH RHEL7 COMMIT] Revert "fs/fuse kio_pcs: add WARN_ON to find race between setattr and write/falloc"

Konstantin Khorenko khorenko at virtuozzo.com
Wed Jul 4 18:06:49 MSK 2018


The commit is pushed to "branch-rh7-3.10.0-862.3.2.vz7.61.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-862.3.2.vz7.61.12
------>
commit 75f075a7db7ad65807eb61d16e17a62e855169ad
Author: Pavel Butsykin <pbutsykin at virtuozzo.com>
Date:   Wed Jul 4 18:06:49 2018 +0300

    Revert "fs/fuse kio_pcs: add WARN_ON to find race between setattr and write/falloc"
    
    This reverts commit 79ee26fdda173d6724c635684b0c72f5e5f66d89.
    
    https://jira.sw.ru/browse/PSBM-85945
    
    Signed-off-by: Pavel Butsykin <pbutsykin at virtuozzo.com>
    Acked-by: Alexey Kuznetsov <kuznet at virtuozzo.com>
---
 fs/fuse/kio/pcs/pcs_fuse_kdirect.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/fs/fuse/kio/pcs/pcs_fuse_kdirect.c b/fs/fuse/kio/pcs/pcs_fuse_kdirect.c
index 258959ed5014..f55a196d5eae 100644
--- a/fs/fuse/kio/pcs/pcs_fuse_kdirect.c
+++ b/fs/fuse/kio/pcs/pcs_fuse_kdirect.c
@@ -771,17 +771,6 @@ static int pcs_fuse_prep_rw(struct pcs_fuse_req *r)
 	spin_lock(&di->lock);
 	/* Deffer all requests if shrink requested to prevent livelock */
 	if (di->size.shrink) {
-		struct inode *inode = &di->inode->inode;
-		struct fuse_conn *fc = get_fuse_conn(inode);
-
-		if (r->req.in.h.opcode == FUSE_WRITE ||
-				r->req.in.h.opcode == FUSE_FALLOCATE) {
-			WARN_ON(1);
-			pr_info("fi->writectr: %d, mutex: %d, fc->lock: %d\n",
-					fi->writectr < 0, mutex_is_locked(&inode->i_mutex),
-					spin_is_locked(&fc->lock));
-		}
-
 		wait_shrink(r, di);
 		spin_unlock(&di->lock);
 		return 1;


More information about the Devel mailing list