[Devel] [PATCH RHEL7 COMMIT] lib/stackdepot.c: use __GFP_NOWARN for stack allocations

Konstantin Khorenko khorenko at virtuozzo.com
Fri Sep 15 17:27:25 MSK 2017


The commit is pushed to "branch-rh7-3.10.0-693.1.1.vz7.37.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git
after rh7-3.10.0-693.1.1.vz7.37.4
------>
commit 3b752e0d639c2b270c28f8dd0ba500666458072e
Author: Kirill A. Shutemov <kirill at shutemov.name>
Date:   Fri Sep 15 17:27:25 2017 +0300

    lib/stackdepot.c: use __GFP_NOWARN for stack allocations
    
    This (large, atomic) allocation attempt can fail.  We expect and handle
    that, so avoid the scary warning.
    
    Link: http://lkml.kernel.org/r/20160720151905.GB19146@node.shutemov.name
    Cc: Andrey Ryabinin <aryabinin at virtuozzo.com>
    Cc: Alexander Potapenko <glider at google.com>
    Cc: Michal Hocko <mhocko at suse.cz>
    Cc: Rik van Riel <riel at redhat.com>
    Cc: David Rientjes <rientjes at google.com>
    Cc: Mel Gorman <mgorman at techsingularity.net>
    Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>
    
    https://jira.sw.ru/browse/PSBM-69081
    (cherry picked from commit 87cc271d5e4320d705cfdf59f68d4d037b3511b2)
    Signed-off-by: Andrey Ryabinin <aryabinin at virtuozzo.com>
---
 lib/stackdepot.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 53ad6c0..60f77f1 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -242,6 +242,7 @@ depot_stack_handle_t depot_save_stack(struct stack_trace *trace,
 		 */
 		alloc_flags &= ~GFP_ZONEMASK;
 		alloc_flags &= (GFP_ATOMIC | GFP_KERNEL);
+		alloc_flags |= __GFP_NOWARN;
 		page = alloc_pages(alloc_flags, STACK_ALLOC_ORDER);
 		if (page)
 			prealloc = page_address(page);


More information about the Devel mailing list